7.1 HR Integration Review: #205733: IDE locks up after using CutToLineBeginOrEndAction

Jan Lahoda <[email protected]> Thu, 01 Dec 2011 13:06:40 +0100
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
http://netbeans.org/bugzilla/show_bug.cgi?id=205733

Description:
The IDE deadlocks after using the CutToLineBeginOrEndAction (not bound 
to any shortcut by default in the default keymap). The reason is that 
the implementation of JavaCutAction expects to be run outside a document 
write-lock, but is run inside the lock in this case.

Fix:
The fix is two-fold: the JavaCutAction is modified to prevent deadlocks 
in case it is run inside the document write-lock, and a new subclass of 
CutToLineBeginOrEndAction is introduced, that ensures the 
transfer-types-on-paste still works even when this action is used by the 
user.

Risk: small. Will prevent transfering the types on paste in cases that 
would lead to a deadlock.

Changeset:
http://hg.netbeans.org/jet-main/rev/abb5e6c4aae2

Fix reviewed by dbalek and verified by jiriprox.

Thanks,
    Jan