NPE from Eclipse bundles during tests

Jaroslav Tulach <[email protected]> Thu, 1 Dec 2011 16:46:16 +0100
Newsgroups gmane.comp.java.netbeans.reviewers
Organization Oracle
Message-ID <[email protected]>
http://netbeans.org/bugzilla/show_bug.cgi?id=205653

The startlevel of OSGi bundles is now controlled by branding. However that 
means NbModuleSuite does not know about it as it ignores branding (bug  
197066). After fixing 205019 this is however a serious problem and influences 
not only tests, but might influence even users.

Fix: Ant harness adds test-xyz-sys-prop.branding.token. In case of NetBeans 
projects, this is hardcoded. In case of Standalone suites, it is read from 
${suite.dir}/nbproject/project.properties. NbModuleSuite then uses this 
property.

Risk: Reporter verified and otherwise low risk, as at most some tests won't 
have proper branding.

Waiting for review by Jesse Glick especially for the apisupport.harness part 
of the patch.