HR integration review request: 225021 - Long time spent in the LuceneIndex._store() by method removing the used data.

Tomas Zezula <[email protected]> Thu, 17 Jan 2013 14:25:10 +0100
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Description:
http://netbeans.org/bugzilla/show_bug.cgi?id=225021

The LuceneIndex._store() takes significant time when long ArrayList of documents is passed to it for storing.

Impact assessment: Slows down scanning.

Risk assessment: low - simple fix, for ArrayList don't do expensive Iterator.remove() but ListIterator.set(null).

Reviewed by Dusan Balek. QA verification by Jiri Prox.

Changesets:
http://hg.netbeans.org/jet-main/rev/467a8519ac68

Thanks for review,
Tomas