HR integration review request: #224988 - Null Pointer Dereference warning for @Nullable fields when field processing is disabled

Jan Lahoda <[email protected]> Thu, 17 Jan 2013 15:47:17 +0100
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Description:
http://netbeans.org/bugzilla/show_bug.cgi?id=224988

An incorrect warning is shown when dereferencing unqualified @Nullable 
fields when the Nullpointer Dereference hint is
configured to not analyze fields (which is the default). The reason is 
that the analysis is not performed
(so the real status of the field is unknown), but its status is read 
from the annotations, leading to incorrect
warning.

Impact assessment: embarrassing warning on field dereferences when 
fields analysis is disabled.

Risk assessment: low - only the hint itself is modified, the processing 
of unqualified fields is made similar to
processing of qualified fields ("this.field").

Reviewed by Dusan Balek. QA verification by Jirka Prox.

Changeset:
http://hg.netbeans.org/jet-main/rev/3ddeec92da07

Thanks for review,
     Jan