HR integration review request: #225107 - Pull Up Method To Abstract Super Class Ads Extraneous Comments
Jan Lahoda <[email protected]> Mon, 21 Jan 2013 17:31:53 +0100
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Description:
http://netbeans.org/bugzilla/show_bug.cgi?id=225107
When refactoring copies parts of code from one file to another, some
code snippets may incorrectly contain duplicates of comments from the
target file. The bug does not manifest itself in development builds
because when assertions were enabled, additional debugging checks were
done and the comment mapping was disabled. The hotfix for 7.3 is
basically to enable these additional checks and disable the comment
mapping even when assertions are disabled.
Impact: incorrect comments appearing in the source code after refactoring.
Risk: as the fix basically only changes a code path from
assertions-enabled-only to always-enabled, the result should not be
worse than an ordinary dev build. Two possible risks are: performance
worse that in ordinary release build (but not worse than in an ordinary
dev) and a very corner case behavioral change for code that was never
tested with assertions enabled.
Reviewed by Dusan Balek. QA verification by Jirka Prox.
Changeset:
http://hg.netbeans.org/jet-main/rev/cf3650a5a9f8
Thanks for review,
Jan