HR integration review request: #225087 - Undo breaks the code after save when removing of trailing whitespaces on save is enabled (edit)

Miloslav Metelka <[email protected]> Tue, 22 Jan 2013 15:35:11 +0100
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]>
Description:
http://netbeans.org/bugzilla/show_bug.cgi?id=225087

Undo breaks the code after save when removing of trailing whitespaces 
(most visibly if it's set to "All Lines" in Tools->Options->Editor->On 
Save).
  The problem is that the edits generated by on-save action are not 
added to undo queue so subsequent undo peforms edits at wrong offsets.

Impact assessment: Problematic behavior only occurs if on-save actions 
are enabled but if it occurs it breaks the code.

Risk assessment: low - mainly fixed an invalid assert

Reviewed by Jan Lahoda. QA verification by Jirka Prox.

Changeset:
http://hg.netbeans.org/jet-main/rev/2ada0c01559e

Thanks for review,
Mila