Please review fix for issue #235439

Petr Pisl <[email protected]> Wed, 04 Sep 2013 08:59:12 +0200
Newsgroups gmane.comp.java.netbeans.reviewers
Message-ID <[email protected]> 
This is a multi-part message in MIME format.
--------------080701050407000705000707
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Please review fix for issue #235439 - Broken file parsing after using 
prototype's property
https://netbeans.org/bugzilla/show_bug.cgi?id=235439

The bulk of the features in JavaScritp editor is based on a model. The 
creation of the model has currently bug, that if a function usage is in 
the code sooner (from parser point of view) then its declaration, then 
the declaration of the function is not created in the model. It 
influence only functions that has name in the declaration.

The current state doesn't create model of such function. It means, if 
the function represents an object (it's constructor), then this object 
misses in the model. Then the majority of the features (navigator, mark 
occurrences, code completion, coloring) doesn't work as we expect.

There is no big risk, because so far such situation was detected, but 
the building the model of such function was canceled.

The change set is here: http://hg.netbeans.org/web-main/rev/fcd6cb67a0dc

The fix was reviewed by Petr Hejl and QA already verified it.

Thanks,
Petr

--------------080701050407000705000707
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="content-type" content="text/html;
      charset=ISO-8859-1">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Please review fix for issue #235439 - Broken file parsing after
    using prototype's property<br>
    <meta http-equiv="content-type" content="text/html;
      charset=ISO-8859-1">
    <a href="https://netbeans.org/bugzilla/show_bug.cgi?id=235439">https://netbeans.org/bugzilla/show_bug.cgi?id=235439</a><br>
    <br>
    The bulk of the features in JavaScritp editor is based on a model.
    The creation of the model has currently bug, that if a function
    usage is in the code sooner (from parser point of view) then its
    declaration, then the declaration of the function is not created in
    the model. It influence only functions that has name in the
    declaration.<br>
    <br>
    The current state doesn't create model of such function. It means,
    if the function represents an object (it's constructor), then this
    object misses in the model. Then the majority of the features
    (navigator, mark occurrences, code completion, coloring) doesn't
    work as we expect.<br>
    <br>
    There is no big risk, because so far such situation was detected,
    but the building the model of such function was canceled.<br>
    <br>
    The change set is here: <a
      href="http://hg.netbeans.org/web-main/rev/fcd6cb67a0dc">http://hg.netbeans.org/web-main/rev/fcd6cb67a0dc</a><br>
    <br>
    The fix was reviewed by Petr Hejl and QA already verified it.<br>
    <br>
    Thanks,<br>
    Petr<br>
  </body>
</html>

--------------080701050407000705000707--