HR fix for issue #235252
Petr Pisl <[email protected]> Wed, 04 Sep 2013 10:46:58 +0200
| Newsgroups | gmane.comp.java.netbeans.reviewers |
|---|---|
| Message-ID | <[email protected]> |
Hello, I would like to ask for the review of the fix issue #235252 - Completion for location object is broken without preceding window https://netbeans.org/bugzilla/show_bug.cgi?id=235252 The global variables in JavaScript are also all properties of window object, if the source file is targeted to run in a browser. window object is a copy of Window object plus many properties. When a global variable is resolved, then NetBeans find out, whether the global variable is not a property of window object, but doesn't look whether is a property of Window.prototype object. The fix correct this. There shouldn't be a risk of the fix. It looks to the index for all properties of Window.prototype object and returns the right type, if such property exists. Petr Hejl is reviewing the fix and Vlada Riha will verify it for QA. Thanks, Petr