Re: Re: NOP ATHROW hack defeated !

Good news! So far all the example cases I had found which triggered
the bad transform now appear to work! Hooray!

I will start a complete test run in JRuby to confirm everything works.

- Charlie

On Thu, Jun 9, 2011 at 7:22 AM, Charles Oliver Nutter
<[email protected]> wrote:
> I will give it a shot and let you know. Thanks!
>
> - Charlie
>
> On Thu, Jun 9, 2011 at 2:15 AM,  <[email protected]> wrote:
>> the ASM patch I sent a few weeks ago had a bug: it was updating the exception handler list, without updating the number of elements in this list (in 'handlerCount'). Here is a new version which fixes this issue. Does it solve your problem?
>>
>> Eric
>>
>> 07/06/2011 23:02, Charles Oliver Nutter wrote:
>>> Sorry, here's that link.
>>>
>>> https://gist.github.com/1013088
>>>
>>> On Tue, Jun 7, 2011 at 4:02 PM, Charles Oliver Nutter
>>> <[email protected]>  wrote:
>>>> Ok, here's ASMifier output of a class that breaks. I turned off stack
>>>> map calculation so it wouldn't do the rewriting. Hopefully modifying
>>>> this to turn the stack map calculation back on will trigger the
>>>> problem. I'll play with it more, but this is at least a start at it...
>>>>
>>>> - Charlie
>>>>
>>>> On Tue, Jun 7, 2011 at 3:24 PM, Charles Oliver Nutter
>>>> <[email protected]>  wrote:
>>>>> Trying to get you something right now; It will probably have JRuby
>>>>> dependencies, but I can try to strip them out later if possible. At
>>>>> least it will give you an example to go on.
>>>>>
>>>>> - Charlie
>>>>>
>>>>> On Sat, May 21, 2011 at 4:58 AM, Eric Bruneton<[email protected]>  wrote:
>>>>>> 18/05/2011 22:28, Charles Oliver Nutter wrote:
>>>>>>>
>>>>>>> Now I have a case where the ASM dead code rewriting breaks on Java 7
>>>>>>> but not Java 6:
>>>>>>> So it's a while loop with a break inside a rescued method body. The
>>>>>>> code emitted for the while loop looks like this:
>>>>>>>
>>>>>>>     L5
>>>>>>>      LINENUMBER 2 L5
>>>>>>>      GOTO L6
>>>>>>>     L7
>>>>>>>     L8
>>>>>>>      LINENUMBER 3 L8
>>>>>>>      ALOAD 1
>>>>>>>      GETFIELD org/jruby/runtime/ThreadContext.nil :
>>>>>>> Lorg/jruby/runtime/builtin/IRubyObject;
>>>>>>>      GOTO L9
>>>>>>>     L10
>>>>>>>      POP
>>>>>>>     L6
>>>>>>>      ALOAD 9
>>>>>>>      INVOKEINTERFACE org/jruby/runtime/builtin/IRubyObject.isTrue ()Z
>>>>>>>      IFNE L7
>>>>>>
>>>>>> can you send us the corresponding ASMifier code (for the whole
>>>>>> method/class), so that we can reproduce the bug?
>>>>>>
>>>>>> Eric
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>

-- 
You receive this message as a subscriber of the [email protected] mailing list.
To unsubscribe: mailto:[email protected]
For general help: mailto:[email protected]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws