Re: Re: [Findbugs-core] Fwd: toward ASM 4.0?

On 08/16/2011 06:45 PM, Eric Bruneton wrote:
> 16/08/2011 09:33, Bill Pugh wrote:
>> I'm looking at the feasibility of moving FindBugs to ASM 4.0.
>>
>> Moving to 4.0_RC1 was fairly trivial. I just needed to provide an
>> implementation of visitInvokeDynamic in a MethodVisitor.
>>
>> However, the changes between 4.0_RC1 and 4.0 seem to be a showstopper.
>>
>>> we mostly
>>> renamed the package from org.objectweb.asm to org.ow2.asm, and we
>>> renamed two classes (MethodHandle to Handle, and MethodType to Type)
>
> Eugene proposed to rename the package so that users will not need to 
> rename it themselves to avoid binary incompatibilities (it seems some 
> products include 4 or 5 repackaged versions of ASM). From what you 
> say, it seems that whatever the option we choose, some users will not 
> be satisfied :-(

It's perhaps better to rollback the renaming patch.

>
>> This is going to require updating all references to asm classes within
>> FindBugs, and more importantly, will /completely break /any third-party
>> bug detectors written using ASM.
>>
>> I don't know how many of those there are. But breaking them all seems
>> rather rude, and a good way to discourage people from writing ASM based
>> detectors in the feature.
>>
>> At Google, and probably elsewhere, they have a very strict policy of
>> using only one version of a third-party library. So it would be hard to
>> update FindBugs inside Google to use ASM 4.0 unless I migrated all uses
>> of ASM to 4.0. Which would be a lot of work.
>>
>> If you really want to completely rename the packages, I'd suggest making
>> the new release be NewASM 1.0. That would allow for NewASM 1.0 and ASM
>> 3.3 to co-exist.

ASM 3.3 must die fast.
By example, if you try to use findbugs with JRuby on a 1.7 VM,
you get an exception from ASM3.3
because it doesn't support JDK7 class file format.

so if we want two ASMs, it should be ASM 4.0 and NewASM 1.0.

>>
>> Bill

Rémi

-- 
You receive this message as a subscriber of the [email protected] mailing list.
To unsubscribe: mailto:[email protected]
For general help: mailto:[email protected]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws