Re: Re: Suggestion for Printer API in ASM 4.0

  I am also against using annotations for this purpose. JavaDocs are
more suitable for such purpose.

  regards,
  Eugene

On Mon, Sep 5, 2011 at 3:00 PM,  <[email protected]> wrote:
> Andrey Loskutov wrote:
>> looking at the current org.objectweb.asm.util.Printer class code in
>> 4.0
>> RC2 I wish me (due the transition from interfaces to classes) a clear
>>
>> indication which methods are for which visitor. Sometimes it is clear
>> from
>> the method name, but sometimes I really need to look at the call
>> hierarchy. As the Printer class now contains methods called from 4
>> different visitors, it is hard to understand.
>>
>> I think one could put four annotations (with
>> @Retention(RetentionPolicy.SOURCE)) to appropriate "visit" method to
>> make
>> clear which visitor calls which method. As those annotations are only
>> for
>> the source, there should be no impact on the jar size/compatibility
>> with
>> pre-1.5 VM's.
>
> I think we can get the same effect with appropriate Javadoc comments (if we make sure to specify the kind of visit event right at the beginning of the javadoc of each method).
>
> Eric
>
>
> --
> You receive this message as a subscriber of the [email protected] mailing list.
> To unsubscribe: mailto:[email protected]
> For general help: mailto:[email protected]?subject=help
> OW2 mailing lists service home page: http://www.ow2.org/wws
>
>

-- 
You receive this message as a subscriber of the [email protected] mailing list.
To unsubscribe: mailto:[email protected]
For general help: mailto:[email protected]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws