Re: Move to support jdk 12
Evgeny Mandrikov <[email protected]> Tue, 26 Jun 2018 14:15:56 +0200
| Newsgroups | gmane.comp.java.objectweb.asm |
|---|---|
| Message-ID | <CAEPFu68oFXn-1WqmmVTnfX5RMECMuNVw3Rk5cajkKz2m9zQJ6Q@mail.gmail.com> |
Maybe by default ( i.e. on machines of contributors ) you can require one JDK with compilation into 1.6 , while use scheme with two JDKs in CI environment and for releases ? On Tue, Jun 26, 2018 at 2:09 PM <[email protected]> wrote: > > > ------------------------------ > > *De: *"Evgeny Mandrikov" <[email protected]> > *À: *"Remi Forax" <[email protected]> > *Cc: *"asm" <[email protected]> > *Envoyé: *Mardi 26 Juin 2018 12:13:42 > *Objet: *Re: [asm] Move to support jdk 12 > > Hi Remi, > Wondering why not use two JDKs - one for compilation, one for tests? > > > Hi Evgeny, > we want people to contribute to ASM, submit merge/pull requests, etc ? > > so the setup has to be simple. > > Rémi > > > > On Tue, Jun 26, 2018 at 10:08 AM Remi Forax <[email protected]> wrote: > >> Hi all, >> the jdk 11 will be the last version to support the java 6 compilation >> target, >> the version 12 of javac will soon remove the support of java 6. >> >> Given that we need java 8 to run the test, i think we should use java 8 >> as target for the code and re-write the bytecode to still be 1.5 compatible >> (currently we only do 1.6 to 1.5), >> as far i as know, it means at least to rewrite all occurences of >> invokestatic Objects.requiresNonNull + pop to invokevirtual Object.getClass >> (javac 7 generates Objects.requiresNonNull to do a null check). Is there >> any other changes we need to do to still be java 5 compatible ? >> >> regards, >> Rémi >> >> >> -- >> You receive this message as a subscriber of the [email protected] mailing list. >> To unsubscribe: mailto:[email protected] >> For general help: mailto:[email protected]?subject=help >> OW2 mailing lists service home page: http://www.ow2.org/wws >> > > -- You receive this message as a subscriber of the [email protected] mailing list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help OW2 mailing lists service home page: http://www.ow2.org/wws