Re: ASM 8.0 released

[email protected] Sat, 4 Apr 2020 19:46:48 +0200 (CEST)
Newsgroups gmane.comp.java.objectweb.asm
Message-ID <[email protected]> 
This is a multi-part message in MIME format...

------------=_1586022414-7190-0
Content-Type: multipart/alternative; 
	boundary="=_959ac206-0133-4ddb-b7e7-a28d29843a51"

--=_959ac206-0133-4ddb-b7e7-a28d29843a51
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

No,=20
the new version is 8.0.1.=20

regards,=20
R=C3=A9mi=20

> De: "Vicente Romero" <[email protected]>
> =C3=80: "Remi Forax" <[email protected]>
> Cc: "Eric Bruneton" <[email protected]>, "asm" <[email protected]>
> Envoy=C3=A9: Vendredi 3 Avril 2020 01:18:15
> Objet: Re: [asm] ASM 8.0 released

> done, the tests that were failing are passing now. I will do some more br=
oad
> testing, will this be version 8.1?

> Thanks,
> Vicente

> On 4/2/20 2:06 PM, Vicente Romero wrote:

>> Hi,

>> Thanks for the fix, I will give it a try later today,

>> Vicente

>> On 4/2/20 1:57 PM, Remi Forax wrote:

>>> Hi Vicente,
>>> We have just patch the issue with empty records.

>>> Can you clone: [ mailto:[email protected]:asm/asm.git |
>>> [email protected]:asm/asm.git ] build it:
>>>   ./gradle/gradlew
>>> and test with the jar inside asm/build/libs ?

>>> regards,
>>> R=C3=A9mi

>>> ----- Mail original -----

>>>> De: "Remi Forax" [ mailto:[email protected] | <[email protected]> ] =
=C3=80: "Eric
>>>> Bruneton" [ mailto:[email protected] | <[email protected]> ] Cc: "Vice=
nte
>>>> Romero" [ mailto:[email protected] | <[email protected]=
m> ] ,
>>>> "asm" [ mailto:[email protected] | <[email protected]> ] Envoy=C3=A9: Mardi 31 Mar=
s 2020
>>>> 16:45:40
>>>> Objet: Re: [asm] ASM 8.0 released

>>>> ----- Mail original -----

>>>>> De: "Eric Bruneton" [ mailto:[email protected] | <[email protected]> =
] =C3=80: "Remi
>>>>> Forax" [ mailto:[email protected] | <[email protected]> ] Cc: "Vicent=
e Romero"
>>>>> [ mailto:[email protected] | <[email protected]> ] , =
"asm" [
>>>>> mailto:[email protected] | <[email protected]> ] Envoy=C3=A9: Mardi 31 Mars 2020 =
15:54:36
>>>>> Objet: Re: [asm] ASM 8.0 released

>>>>> Should we add an ACC_RECORD pseudo access flag for this (similar to
>>>>> ACC_INTERFACE)?

>>>> yes !
>>>> it's a far better idea than mine (add a RecordVisitor interface which =
is not a
>>>> backward compatible change).

>>>> R=C3=A9mi

>>>>> ----- Mail original -----

>>>>>> De: "Remi Forax" [ mailto:[email protected] | <[email protected]> ] =
=C3=80: "Remi
>>>>>> Forax" [ mailto:[email protected] | <[email protected]> ] Cc: "Vicen=
te Romero"
>>>>>> [ mailto:[email protected] | <[email protected]> ] ,=
 "Eric
>>>>>> Bruneton" [ mailto:[email protected] | <[email protected]> ] , "asm"=
 [
>>>>>> mailto:[email protected] | <[email protected]> ] Envoy=C3=A9: Mardi 31 Mars 2020=
 12:12:49
>>>>>> Objet: Re: [asm] ASM 8.0 released

>>>>>> But it's a backward incompatible change :(

>>>>>> R=C3=A9mi

>>>>>> ----- Mail original -----

>>>>>> De: "Remi Forax" [ mailto:[email protected] | <[email protected]> ] =
=C3=80: "Vicente
>>>>>> Romero" [ mailto:[email protected] | <vicente.romero@oracle.=
com> ] Cc:
>>>>>> "Eric Bruneton" [ mailto:[email protected] | <[email protected]> ] ,=
 "asm" [
>>>>>> mailto:[email protected] | <[email protected]> ] Envoy=C3=A9: Mardi 31 Mars 2020=
 12:02:25
>>>>>> Objet: Re: [asm] ASM 8.0 released

>>>>>> oops,

>>>>>> my bad, will fix that ASAP !

>>>>>> R=C3=A9mi

>>>>>> ----- Mail original -----

>>>>>> De: "Vicente Romero" [ mailto:[email protected] |
>>>>>> <[email protected]> ] =C3=80: "Eric Bruneton" [ mailto:ebrun=
[email protected] |
>>>>>> <[email protected]> ] , "asm" [ mailto:[email protected] | <[email protected]> ]=
 Envoy=C3=A9:
>>>>>> Mardi 31 Mars 2020 03:14:35
>>>>>> Objet: Re: [asm] ASM 8.0 released

>>>>>> Hi,

>>>>>> Thanks for publishing this version, it is great to see it supporting
>>>>>> records, yay! I was testing it to include it in JDK 15 and I think I
>>>>>> found a bug which is related to records with no record components as
>>>>>> in:

>>>>>> $ cat R.java
>>>>>> record R() {}

>>>>>> if we compile this record with javac we will see in javap's output an
>>>>>> empty `Record` attribute but lets say we use the simplest ASM client
>>>>>> as in:

>>>>>> import java.io.FileInputStream;
>>>>>> import java.io.FileOutputStream;

>>>>>> import org.objectweb.asm.ClassReader;
>>>>>> import org.objectweb.asm.ClassWriter;

>>>>>> public class ASMRecordTest {
>>>>>> public static void main(final String args[]) throws Exception {
>>>>>> FileInputStream is =3D new FileInputStream(args[0]);

>>>>>> ClassReader cr =3D new ClassReader(is);
>>>>>> ClassWriter cw =3D new ClassWriter(ClassWriter.COMPUTE_FRAMES);
>>>>>> cr.accept(cw, 0);

>>>>>> FileOutputStream fos =3D new FileOutputStream(args[1]);
>>>>>> fos.write(cw.toByteArray());
>>>>>> fos.close();
>>>>>> }
>>>>>> }

>>>>>> if this program is invoked with arguments: /path/to/R.class
>>>>>> /path/to/R2.class we will see that R2.class is missing the `Record`
>>>>>> attribute. The issue in the current code in ASM is that no record
>>>>>> attribute will be written unless there is at least one record
>>>>>> component.

>>>>>> Thanks,
>>>>>> Vicente

>>>>>> On 3/28/20 8:07 AM, [ mailto:[email protected] | [email protected] ]=
 wrote:

>>>>>> Release notes:
>>>>>> - Java 14 support (RecordComponent)
>>>>>> - bug fixes
>>>>>>   * 317896: Performance degradation when using dynamic constants as a
>>>>>>   static parameter to another InDy/ConDy

>>>>>> The ASM team

>>>>>> --
>>>>>> You receive this message as a subscriber of the [ mailto:[email protected]=
 |
>>>>>> [email protected] ] mailing
>>>>>> list.
>>>>>> To unsubscribe: [ mailto:[email protected] |
>>>>>> mailto:[email protected] ] For general help: [
>>>>>> mailto:[email protected]?subject=3Dhelp | mailto:[email protected]?subject=
=3Dhelp ] OW2
>>>>>> mailing lists service home page: [ http://www.ow2.org/wws |
>>>>>> http://www.ow2.org/wws ] --
>>>>>> You receive this message as a subscriber of the [ mailto:[email protected]=
 |
>>>>>> [email protected] ] mailing
>>>>>> list.
>>>>>> To unsubscribe: [ mailto:[email protected] |
>>>>>> mailto:[email protected] ] For general help: [
>>>>>> mailto:[email protected]?subject=3Dhelp | mailto:[email protected]?subject=
=3Dhelp ] OW2
>>>>>> mailing lists service home page: [ http://www.ow2.org/wws |
>>>>>> http://www.ow2.org/wws ]

>>>> --
>>>> You receive this message as a subscriber of the [ mailto:[email protected] |
>>>> [email protected] ] mailing list.
>>>> To unsubscribe: [ mailto:[email protected] |
>>>> mailto:[email protected] ] For general help: [
>>>> mailto:[email protected]?subject=3Dhelp | mailto:[email protected]?subject=3Dh=
elp ] OW2
>>>> mailing lists service home page: [ http://www.ow2.org/wws |
>>>> http://www.ow2.org/wws ]

--=_959ac206-0133-4ddb-b7e7-a28d29843a51
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><body><div style=3D"font-family: arial, helvetica, sans-serif; font-s=
ize: 12pt; color: #000000"><div>No,<br></div><div>the new version is 8.0.1.=
<br data-mce-bogus=3D"1"></div><div><br data-mce-bogus=3D"1"></div><div>reg=
ards,<br data-mce-bogus=3D"1"></div><div>R=C3=A9mi<br data-mce-bogus=3D"1">=
</div><div><br></div><hr id=3D"zwchr" data-marker=3D"__DIVIDER__"><div data=
-marker=3D"__HEADERS__"><blockquote style=3D"border-left:2px solid #1010FF;=
margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:n=
ormal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size=
:12pt;"><b>De: </b>"Vicente Romero" &lt;[email protected]&gt;<br><b=
>=C3=80: </b>"Remi Forax" &lt;[email protected]&gt;<br><b>Cc: </b>"Eric Bru=
neton" &lt;[email protected]&gt;, "asm" &lt;[email protected]&gt;<br><b>Envoy=C3=
=A9: </b>Vendredi 3 Avril 2020 01:18:15<br><b>Objet: </b>Re: [asm] ASM 8.0 =
released<br></blockquote></div><div data-marker=3D"__QUOTED_TEXT__"><blockq=
uote style=3D"border-left:2px solid #1010FF;margin-left:5px;padding-left:5p=
x;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font=
-family:Helvetica,Arial,sans-serif;font-size:12pt;">done, the tests that we=
re failing are passing now. I will do some
    more broad testing, will this be version 8.1?<br>
    <br>
    Thanks,<br>
    Vicente<br>
    <br>
    <div class=3D"moz-cite-prefix">On 4/2/20 2:06 PM, Vicente Romero
      wrote:<br>
    </div>
    <blockquote cite=3D"mid:[email protected]=
">
=20=20=20=20=20=20
      Hi,<br>
      <br>
      Thanks for the fix, I will give it a try later today,<br>
      <br>
      Vicente<br>
      <br>
      <div class=3D"moz-cite-prefix">On 4/2/20 1:57 PM, Remi Forax wrote:<b=
r>
      </div>
      <blockquote cite=3D"mid:1909087150.612930.1585850238541.JavaMail.zimb=
[email protected]">
        <pre class=3D"moz-quote-pre">Hi Vicente,
We have just patch the issue with empty records.

Can you clone:=20
  <a class=3D"moz-txt-link-abbreviated" href=3D"mailto:[email protected]:a=
sm/asm.git" target=3D"_blank">[email protected]:asm/asm.git</a>
build it:
  ./gradle/gradlew
and test with the jar inside asm/build/libs ?

regards,
R=C3=A9mi

----- Mail original -----
</pre>
        <blockquote>
          <pre class=3D"moz-quote-pre">De: "Remi Forax" <a class=3D"moz-txt=
-link-rfc2396E" href=3D"mailto:[email protected]" target=3D"_blank">&lt;for=
[email protected]&gt;</a>
=C3=80: "Eric Bruneton" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:e=
[email protected]" target=3D"_blank">&lt;[email protected]&gt;</a>
Cc: "Vicente Romero" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:vice=
[email protected]" target=3D"_blank">&lt;[email protected]&gt;<=
/a>, "asm" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:[email protected]" t=
arget=3D"_blank">&lt;[email protected]&gt;</a>
Envoy=C3=A9: Mardi 31 Mars 2020 16:45:40
Objet: Re: [asm] ASM 8.0 released
</pre>
        </blockquote>
        <blockquote>
          <pre class=3D"moz-quote-pre">----- Mail original -----
</pre>
          <blockquote>
            <pre class=3D"moz-quote-pre">De: "Eric Bruneton" <a class=3D"mo=
z-txt-link-rfc2396E" href=3D"mailto:[email protected]" target=3D"_blank">&l=
t;[email protected]&gt;</a>
=C3=80: "Remi Forax" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:fora=
[email protected]" target=3D"_blank">&lt;[email protected]&gt;</a>
Cc: "Vicente Romero" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:vice=
[email protected]" target=3D"_blank">&lt;[email protected]&gt;<=
/a>, "asm" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:[email protected]" t=
arget=3D"_blank">&lt;[email protected]&gt;</a>
Envoy=C3=A9: Mardi 31 Mars 2020 15:54:36
Objet: Re: [asm] ASM 8.0 released
</pre>
          </blockquote>
          <blockquote>
            <pre class=3D"moz-quote-pre">Should we add an ACC_RECORD pseudo=
 access flag for this (similar to
ACC_INTERFACE)?
</pre>
          </blockquote>
          <pre class=3D"moz-quote-pre">yes !
it's a far better idea than mine (add a RecordVisitor interface which is no=
t a
backward compatible change).

R=C3=A9mi

</pre>
          <blockquote>
            <pre class=3D"moz-quote-pre">----- Mail original -----
</pre>
            <blockquote>
              <pre class=3D"moz-quote-pre">De: "Remi Forax" <a class=3D"moz=
-txt-link-rfc2396E" href=3D"mailto:[email protected]" target=3D"_blank">&lt=
;[email protected]&gt;</a>
=C3=80: "Remi Forax" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:fora=
[email protected]" target=3D"_blank">&lt;[email protected]&gt;</a>
Cc: "Vicente Romero" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:vice=
[email protected]" target=3D"_blank">&lt;[email protected]&gt;<=
/a>, "Eric Bruneton"
<a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:[email protected]" target=
=3D"_blank">&lt;[email protected]&gt;</a>, "asm" <a class=3D"moz-txt-link-r=
fc2396E" href=3D"mailto:[email protected]" target=3D"_blank">&lt;[email protected]&gt;<=
/a>
Envoy=C3=A9: Mardi 31 Mars 2020 12:12:49
Objet: Re: [asm] ASM 8.0 released



But it's a backward incompatible change :(



R=C3=A9mi


----- Mail original -----



De: "Remi Forax" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:forax@un=
iv-mlv.fr" target=3D"_blank">&lt;[email protected]&gt;</a>
=C3=80: "Vicente Romero" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:=
[email protected]" target=3D"_blank">&lt;[email protected]&=
gt;</a>
Cc: "Eric Bruneton" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:ebrun=
[email protected]" target=3D"_blank">&lt;[email protected]&gt;</a>, "asm" <a cla=
ss=3D"moz-txt-link-rfc2396E" href=3D"mailto:[email protected]" target=3D"_blank">=
&lt;[email protected]&gt;</a>
Envoy=C3=A9: Mardi 31 Mars 2020 12:02:25
Objet: Re: [asm] ASM 8.0 released





oops,

my bad, will fix that ASAP !


R=C3=A9mi

----- Mail original -----



De: "Vicente Romero" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:vice=
[email protected]" target=3D"_blank">&lt;[email protected]&gt;<=
/a>
=C3=80: "Eric Bruneton" <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:e=
[email protected]" target=3D"_blank">&lt;[email protected]&gt;</a>, "asm" <a=
 class=3D"moz-txt-link-rfc2396E" href=3D"mailto:[email protected]" target=3D"_bla=
nk">&lt;[email protected]&gt;</a>
Envoy=C3=A9: Mardi 31 Mars 2020 03:14:35
Objet: Re: [asm] ASM 8.0 released



Hi,

Thanks for publishing this version, it is great to see it supporting
records, yay! I was testing it to include it in JDK 15 and I think I
found a bug which is related to records with no record components as
in:

$ cat R.java
record R() {}

if we compile this record with javac we will see in javap's output an
empty `Record` attribute but lets say we use the simplest ASM client
as in:

import java.io.FileInputStream;
import java.io.FileOutputStream;

import org.objectweb.asm.ClassReader;
import org.objectweb.asm.ClassWriter;

public class ASMRecordTest {
public static void main(final String args[]) throws Exception {
FileInputStream is =3D new FileInputStream(args[0]);

ClassReader cr =3D new ClassReader(is);
ClassWriter cw =3D new ClassWriter(ClassWriter.COMPUTE_FRAMES);
cr.accept(cw, 0);

FileOutputStream fos =3D new FileOutputStream(args[1]);
fos.write(cw.toByteArray());
fos.close();
}
}

if this program is invoked with arguments: /path/to/R.class
/path/to/R2.class we will see that R2.class is missing the `Record`
attribute. The issue in the current code in ASM is that no record
attribute will be written unless there is at least one record
component.

Thanks,
Vicente


On 3/28/20 8:07 AM, <a class=3D"moz-txt-link-abbreviated" href=3D"mailto:eb=
[email protected]" target=3D"_blank">[email protected]</a> wrote:


Release notes:
- Java 14 support (RecordComponent)
- bug fixes
  * 317896: Performance degradation when using dynamic constants as a
  static parameter to another InDy/ConDy

The ASM team



--
You receive this message as a subscriber of the <a class=3D"moz-txt-link-ab=
breviated" href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a> ma=
iling
list.
To unsubscribe: <a class=3D"moz-txt-link-freetext" href=3D"mailto:asm-unsub=
[email protected]" target=3D"_blank">mailto:[email protected]</a>
For general help: <a class=3D"moz-txt-link-freetext" href=3D"mailto:sympa@o=
w2.org?subject=3Dhelp" target=3D"_blank">mailto:[email protected]?subject=3Dhel=
p</a>
OW2 mailing lists service home page: <a class=3D"moz-txt-link-freetext" hre=
f=3D"http://www.ow2.org/wws" target=3D"_blank">http://www.ow2.org/wws</a>


--
You receive this message as a subscriber of the <a class=3D"moz-txt-link-ab=
breviated" href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a> ma=
iling
list.
To unsubscribe: <a class=3D"moz-txt-link-freetext" href=3D"mailto:asm-unsub=
[email protected]" target=3D"_blank">mailto:[email protected]</a>
For general help: <a class=3D"moz-txt-link-freetext" href=3D"mailto:sympa@o=
w2.org?subject=3Dhelp" target=3D"_blank">mailto:[email protected]?subject=3Dhel=
p</a>
OW2 mailing lists service home page: <a class=3D"moz-txt-link-freetext" hre=
f=3D"http://www.ow2.org/wws" target=3D"_blank">http://www.ow2.org/wws</a>
</pre>
            </blockquote>
          </blockquote>
          <pre class=3D"moz-quote-pre">--
You receive this message as a subscriber of the <a class=3D"moz-txt-link-ab=
breviated" href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a> ma=
iling list.
To unsubscribe: <a class=3D"moz-txt-link-freetext" href=3D"mailto:asm-unsub=
[email protected]" target=3D"_blank">mailto:[email protected]</a>
For general help: <a class=3D"moz-txt-link-freetext" href=3D"mailto:sympa@o=
w2.org?subject=3Dhelp" target=3D"_blank">mailto:[email protected]?subject=3Dhel=
p</a>
OW2 mailing lists service home page: <a class=3D"moz-txt-link-freetext" hre=
f=3D"http://www.ow2.org/wws" target=3D"_blank">http://www.ow2.org/wws</a>
</pre>
          <br>
          <fieldset class=3D"mimeAttachmentHeader"></fieldset>
        </blockquote>
      </blockquote>
      <br>
      <br>
      <fieldset class=3D"mimeAttachmentHeader"></fieldset>
      <pre class=3D"moz-quote-pre"></pre>
    </blockquote>
    <br><br></blockquote></div></div></body></html>=

--=_959ac206-0133-4ddb-b7e7-a28d29843a51--

------------=_1586022414-7190-0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit


-- 
You receive this message as a subscriber of the [email protected] mailing list.
To unsubscribe: mailto:[email protected]
For general help: mailto:[email protected]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

------------=_1586022414-7190-0--