[JIRA-OS] Commented: (WF-206) AbstractWorkflow.getVariablesFromMaps unsafe use of PropertySet

The following comment has been added to this issue:

     Author: Hani Suleiman
    Created: Wed, 10 Sep 2003 8:08 PM
       Body:
The problem is with the ofbiz provider it's inconsistent with the other providers and shouldn't be throwing an exception, but I'm not sure of how many people rely on it throwing an exception!
---------------------------------------------------------------------
View the issue:

  http://jira.opensymphony.com/secure/ViewIssue.jspa?key=WF-206


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: WF-206
    Summary: AbstractWorkflow.getVariablesFromMaps unsafe use of PropertySet
       Type: Bug

     Status: Assigned
   Priority: Major

    Project: OSWorkflow

   Assignee: Hani Suleiman
   Reporter: Robert Dawson

    Created: Wed, 3 Sep 2003 11:30 AM
    Updated: Wed, 10 Sep 2003 1:24 PM

Description:
The AbstractWorkflow.getVariablesFromMaps does a straight lookup of the String against the propertyset.  The OFBizPropertySet throws a 
PropertyImplementationException when the property doesn't exist.

I suggest that AbstractWorkflow.getVariablesFromMaps should change:

        if (o == null) {
            o = ps.getAsActualType(actualVar);
        }

to be:
        if (o == null) {
            if (ps.exists(actualVar)){
                o = ps.getAsActualType(actualVar);
            }
        }



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.opensymphony.com/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf