Workflow in Database

I wrote a class to put workflow definitions in a JDBC database,
but I need some patches in osWorkflow to prevent code duplication:

1. WorkflowLoader.java
--> add an additional load method that takes an InputStream instead of an
URL
    /**
     * Load a workflow descriptor from a URL
     */
    public static WorkflowDescriptor load(final URL url) throws
SAXException, IOException {
        return load(url.openStream());
    }

    /**
     * Load a workflow descriptor from an InputStream
     */
    public static WorkflowDescriptor load(final InputStream is) throws
SAXException, IOException {
----

2. Move save() code from XMLWorkflowFactory into a new class similar to
WorkflowLoader, otherwise the code
would need to be duplicated. It's just a small part of code but anyway:

the code could look like that:
public static save(OutputStream os) {
        Writer out = new OutputStreamWriter(os);

        PrintWriter writer = new PrintWriter(new BufferedWriter(out));
        writer.println("<?xml version=\"1.0\" encoding=\"UTF-8\"?>");

        writer.println("<!DOCTYPE workflow PUBLIC \"-//OpenSymphony
Group//DTD OSWorkflow 2.5//EN\"
\"http://www.opensymphony.com/osworkflow/workflow.dtd\">");
        descriptor.writeXML(writer, 0);
        writer.flush();
        writer.close();
}

What do you think? Should I submit a feature request/bug in JIRA?

philipp



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf