[JIRA-Opensymphony] Created: (WF-188) AbstractWorkflow.doAction() does not indicate an illegal action

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:

  http://jira.opensymphony.com/secure/ViewIssue.jspa?key=WF-188


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: WF-188
    Summary: AbstractWorkflow.doAction() does not indicate an illegal action
       Type: Bug

     Status: Assigned
   Priority: Minor

    Project: OSWorkflow
   Versions:
             2.5

   Assignee: Patrick Lightbody
   Reporter: Peter Mayne

    Created: Wed, 30 Jul 2003 9:35 PM
    Updated: Wed, 30 Jul 2003 9:35 PM

Description:
When calling AbstractWorkflow.doAction(), an IllegalArgumentException 
is thrown if the specified workflow entry does not exist, but if the 
specified action does not exist, doAction() merely returns with no 
indication of a problem.

In doAction():

         if (!validAction) {
             return;
         }

should be changed to:

         if (!validAction) {
             throw new IllegalArgumentException("No such action id " + 
 actionId);
         }



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.opensymphony.com/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01