[ openjms-Bugs-964267 ] column indexes, names column in inserts, close all db object

Bugs item #964267, was opened at 2004-06-01 23:24
Message generated for change (Comment added) made by tanderson
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=474136&aid=964267&group_id=54559

Category: persistence
>Group: v0.7.6.1
Status: Open
>Resolution: Fixed
Priority: 5
Submitted By: Michael Jaszczyk (mjaszczyk)
Assigned to: Jim Alateras (jalateras)
Summary: column indexes, names column in inserts, close all db object

Initial Comment:
Changed code to close all db objects using the SQL 
Helper singelton.
Changed all selects to use column indexes instead of 
names, to avoid db roundtrips.
Changed inserts to contains the real column names to 
make them independant of the ordery the columns 
where created in the db.
removed all 'select *' and replaced by the columns 
needed.
Changed some Vectors and Hashtables to 
unsynchronized implmentations wrapper in unmodifyable 
collections.


----------------------------------------------------------------------

>Comment By: Tim Anderson (tanderson)
Date: 2004-07-03 15:14

Message:
Logged In: YES 
user_id=557161

Applied patches to the following classes:
  DurableConsumerEndpoint, Consumers, Destinations,
  MessageHandles, Messages, RDMSAdapter, SQLHelper,
  SeedGenerator, SchemaHelper

Patches have been applied on the openjms_0_7_6_maint 
branch.

Many thanks!

Patches to the following classes *haven't* been applied:

. Users
  This patch breaks the fix for bug 891758 - 'DB table uses 
reserved word as column name'. See:
  http://sourceforge.net/tracker/index.php?
func=detail&aid=891758&group_id=54559&atid=474136

. AdminConnection, JmsAdminServerIfc, 
  IntravmJmsAdminConnection
  Refers to a non-existent interface change.

. BytesMessageConverter
  Performance enhancement unrelated to the bug report.
  Also not clear what benefits it gives. If you want it applied,
  can you raise another bug report, and quantify 
  the performance benefit?

. MessageLeaseHelper, QueueDestinationCache,
  BatchingRDMSAdapter, ObjectAdapter, PersistenceAdapter, 
  
  Vector -> List interface change. I agree that the collections
  API is much cleaner than Vector and friends, but I want
  to leave cosmetic changes to the persistence layer alone
  until it is refactored (probably for the 0.7.7 release).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=474136&aid=964267&group_id=54559


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com