Re: Ran PMD against source tree in branch

Philippe,

regarding @Override before interface implementation, this is correct in
jdk 1.6.

But I think removing it is fine, and jdk1.5 will complain otherwise.

Regarding missing {} with if statments, it is kind of a matter of
taste :) I like it more also, but maybe Anthony has another opinion on
this.

Franck

Le mercredi 23 juillet 2008 à 14:57 +0200, Philippe Back (High Octane) a
écrit :
> Hi Anthony, Franck,
>  
> I ran PMD and there were several warnings.
>  
> Lots of 'if's without {}es. I added these in my local copy.
>  
> Also, there were places where there were no @Override in front of
> overriden methods. I added these in my local copy.
>  
> I also noticed that there are places were there are @Override in front
> of interface methods. Maybe a leftover.
>  
> Some method parameters are not used, so I added a ### comment in the
> method javadoc in my local copy.
>  
> There are also several unused imports that I removed.
>  
> Also corrected some typos.
>  
> Would you have an issue with me commiting these changes ?
>  
> KR
> /Philippe
> 
> No virus found in this outgoing message.
> Checked by AVG.
> Version: 7.5.524 / Virus Database: 270.5.3/1565 - Release Date:
> 21/07/2008 18:36
> 
> 
> 
>  



------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/SimpleORM/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/SimpleORM/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:[email protected] 
    mailto:[email protected]

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/