Re: Ran PMD against source tree in branch

Hello Phil,

The redundant {} are a matter of personal choice as Franck says.  I 
personally don't like them, clutter.    But basically I think this 
sort of detail is up to each developer.  If you change some code then 
format it the way you like, but don't change other peoples code just 
for formatting.

Adding @Overrides is good.   They should go everywhere.  I personally 
like them for implementing abstract methods too -- adds clarity.

Parameters not used and methods not called are worthy of 
investigation.  Please make a list.

Imports are a pain.  I like *, but IDEs "add value" by 
enumeration.  But not important either way.

Whatever you do, make sure you svn diff your current version before 
committing.  There should not be too many non-significant changes.  I 
run my eye over the diff list.

If you have created too much noise then please revert and start 
again.  Otherwise check it in.

But the best place to start is the test cases.  They need work, and 
improving them builds your understanding of SimpleOrm.  Extra data in 
TestUte would be a valuable contribution.

Anthony

At 10:57 PM 23/07/2008, Philippe Back \(High Octane\) wrote:

>Hi Anthony, Franck,
>
>I ran PMD and there were several warnings.
>
>Lots of 'if's without {}es. I added these in my local copy.
>
>Also, there were places where there were no @Override in front of 
>overriden methods. I added these in my local copy.
>
>I also noticed that there are places were there are @Override in 
>front of interface methods. Maybe a leftover.
>
>Some method parameters are not used, so I added a ### comment in the 
>method javadoc in my local copy.
>
>There are also several unused imports that I removed.
>
>Also corrected some typos.
>
>Would you have an issue with me commiting these changes ?
>
>KR
>/Philippe
>
>No virus found in this outgoing message.
>Checked by AVG.
>Version: 7.5.524 / Virus Database: 270.5.3/1565 - Release Date: 
>21/07/2008 18:36
>

Dr Anthony Berglas, [email protected]       Mobile: +61 4 4838 8874
Just because it is possible to push twigs along the ground with ones nose
does not necessarily mean that is the best way to collect firewood.

------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/SimpleORM/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/SimpleORM/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:[email protected] 
    mailto:[email protected]

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/