Re: [picocontainer-dev] patches for *full* binding-annotation capability

Konstantin Priblouda wrote:

> 
> Well, there are different kinds of test. Tests for
> some functionality / class which is gone and replaced
> by something else  going to be broken anyway - as they
> become obsolete.   Test assuring overall behaviour
> have to stay and be satisfied

Sure - but in that case the tests which are obsolete or not relevant 
should be either removed or commented out with a reason (eg 
traceability).  Failing tests on refactor is kinda of red alarm bell to 
me ;-)

> Problem is, that parameter/adapter stuff is pretty
> central to everything - so refactoring is bound to 
> touch anything. 

Understood, but all the more reasons to not let it diverge.
This of course if one intends to merge back.  If the branch is an 
experimental one, whose purpose it is to just try out new ideas, or a 
new major release branch (eg the Pico 2.x branch) but not intended to be 
merged back, then it's a different story.

> Maybe apache project would be a good starting point
> for it - as we also have to cope with demands of
> plexus. 
> 
> for now, I'd fix the branch.
> 
> Anyway, this refactoring is not useless - it already
> unearthed at least one serious bug not seen previously
> ;) 

Of course!  Never intended to imply that it wasn't useful :-)
Was just worried about diverging codebases while we are approaching the 
merge.  I think that the idea of applying the lessons learnt to the 
composer codebase is a good one.

Cheers




---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email