Re: [picocontainer-dev] patches for *full* binding-annotation capability

--- Mauro Talevi <[email protected]> wrote:

> Konstantin Priblouda wrote:

> Sure - but in that case the tests which are obsolete
> or not relevant 
> should be either removed or commented out with a
> reason (eg 
> traceability).  Failing tests on refactor is kinda
> of red alarm bell to 
> me ;-)

While we are at some 600+ unit tests just in core
this will be a big chunk of work  ( I'm down to
8 failures and 83 error now ;) ) 


> Understood, but all the more reasons to not let it
> diverge.
> This of course if one intends to merge back.  If the
> branch is an 
> experimental one, whose purpose it is to just try
> out new ideas, or a 
> new major release branch (eg the Pico 2.x branch)
> but not intended to be 
> merged back, then it's a different story.

Current code is  sometimes a mess - for example
logic for boxing primitives is diplucated or
triplicated ( not sure about quadruplication ;) ) 

adapter and container are heavily gridlocked etc...


> Of course!  Never intended to imply that it wasn't
> useful :-)
> Was just worried about diverging codebases while we
> are approaching the 
> merge.  I think that the idea of applying the
> lessons learnt to the 
> composer codebase is a good one.

Primar puprose of refactoring is to simplify
parameters
from what they are now (  I'm changing it to
aggregation of "extractor" and "lookup" - so you can
combine scalar extraction with "by key" or "by class"
or "by key class"  - the same holds for collection
extraction and config conversion. 

I'd like to have clear separation - adaptor
instantiates / configures , extractor extracts
value[s], lookup looks up components from pico
contaner. 

off to failing unit tests ;)

regards,


----[ Konstantin Pribluda http://www.pribluda.de ]----------------
JTec quality components: http://www.pribluda.de/projects/


      ____________________________________________________________________________________
Be a better sports nut!  Let your teams follow you 
with Yahoo Mobile. Try it now.  http://mobile.yahoo.com/sports;_ylt=At9_qDKvtAbMuh1G1SQtBI7ntAcJ

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email