[GitHub] [roller] DittoTool opened a new pull request #1 04: Inefficient Usage of Java Collections

DittoTool opened a new pull request #104:
URL: https://github.com/apache/roller/pull/104


   Hi,
   
   We find that there are several inefficient usages of Java Collections:
   
   1. The contains method is invoked upon a list object. We recommend replacing it with a HashSet.
   2. There is no iteration occurring upon a TreeMap, thus the insertion order does not matter. We recommend replacing it with a HashMap.
   
   We discovered the above inefficient usage of containers by our tool Ditto. The patch is submitted. Could you please check and accept it? We have tested the patch on our PC. The patched program works well.
   
   Bests
   
   Ditto


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]