[GitHub] [roller] mbien commented on pull request #104 : Inefficient Usage of Java Collections

mbien commented on pull request #104:
URL: https://github.com/apache/roller/pull/104#issuecomment-919713678


   hello @DittoTool
   
   i took a quick look, and beside it not compiling:
   * 850c7a5 getWeblogHandleLetterMap() can't be changed since it is a public service and returns an alphabetically sorted index
   * 7e46a11 RollerPermission would need more work, but since roller has very few permissions, it wouldn't really make a difference performance wise. Additionally: the permissions are persisted as comma separated String, so changing the order randomly might lead to other problems and would need more investigation and testing.
   * b24e89c is example code which uses a hardcoded list of 3 items.
   
   please don't claim that you tested a PR when the changes don't compile (i will give you the benefit of the doubt and assume that the commit is missing something).
   
   (i can't find dittotool on the apache contributors list https://people.apache.org/committer-index.html, so you might have to sign the CLA first before contributing to an apache project: https://www.apache.org/licenses/contributor-agreements.html )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]