Re: [PR] ROL-2183: Migrate from javax to Jakarta EE 10 [ roller]

mraible commented on PR #154:
URL: https://github.com/apache/roller/pull/154#issuecomment-5259915440

   The CI failures here predate the latest push: both runs failed the same way, with the it-selenium test meeting a 503 because the webapp never actually deployed. Debugging that locally turned up a chain of real migration bugs that the branch's only container test had been hiding, now fixed in the last four commits:
   
   - The Jetty 12 plugin renamed `jettyXml` to `jettyXmls` and silently ignored the old name, so the it-selenium harness never loaded jetty.xml, never bound the JNDI datasource, and never started the Derby network server (`Nothing to bind for name jdbc/rollerdb` in the earlier run's log).
   - webjars-servlet-2.x extends the javax `HttpServlet`, so on a Jakarta container it threw `NoClassDefFoundError` at startup and took the whole context down. WebJar assets are now served natively from `META-INF/resources` at the same `/webjars` paths.
   - Spring Security 7's XML config authorizes through `AuthorizationManager`, which denies requests that match no `intercept-url` rule; the old `FilterSecurityInterceptor` allowed them. Every unlisted URL, including the login page itself, redirected to the login page in a loop. An explicit `/**` permitAll rule restores the old behavior.
   - struts2-bootstrap-plugin had been removed as an unused taglib, but it also supplies the FreeMarker templates behind the `theme="bootstrap"` attribute that nearly every form JSP uses, so any page with a form failed with `TemplateNotFoundException`. The Jakarta-native 6.1.0 restores the theme; it emits Bootstrap 5 markup against the current Bootstrap 3 CSS, so some form styling is off until a follow-up converts the UI to Bootstrap 5.
   
   The full Selenium journey (register, log in, create a weblog, publish an entry) and the 157 unit tests pass locally on this branch after these changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]