Issue #SCB1439

Activity report on

  *Enhancement SCB1439 -  AttributeGroup viewing permissions*
 
  Scarab Link: http://www.solitone.org/scarab/issues/id/SCB1439
  Module: Scarab


  Activity generated by  Michael Semb Wever ([email protected])  at 05/09/2008 10:05



  *Comments*
  - By Michael Semb Wever - 05/09/2008 10:05 ---
  "I've committed the merge-back-into-trunk into a new branch http://scarab.tigris.org/source/browse/scarab/branches/SCB1439-take2

There were a few changes done to your initial implementation, not necessarily better code but likely i just had a hard time getting my head around the code...

- Activity.isRestricted() was removed. Activity don't always belong to a valid AttributeGroup, this method didn't test against a user.
- boolean isAttributeVisible(Attribute, ScarabUser) was added to Issue. and used inside getActivity(boolean,int,ScarabUser) to filter which activity to include.
- ViewIssueTab5.vm was rewritten since the rows are now ActivitySets and not individual Activites. Where a non-visible activity was changes the text "A restricted attribute was changed" appears.

I'll fix the email activity as described in my last comment, and commit that too to the new branch. 
please take a peek at it jorge, and give feedback regarding my last comment here. they say 3 days silence is consent :-)"