Re: proposing 2 changes in the email subject

Jorge; The idea of using a template as you describe, was exactly
what i planned to do in first place. But meanwhile i found out, that it
allready has been implemented mostly like this. Only that the
template is implemented with velocity... 

I have an intermediate implementation checked into trunk, which 
IMHO works pretty much better than what we had before. 
Now i can directly see from the subject line what the email is about...

There is still some work to do, so that it is more generic. e.g.
i have hardcoded the decision which ACTION to be used in a particular
case. That should be made at least configurable by properties, or
maybe i can find a way to configure the velocity template so that 
the original template gets replaced by my customized template.
i remember there is a mechanism for that built right into scarab...
wasn't it by placing a template property into the build.properties... ???

Anyways, if you or anybody else had some time to crosscheck my
current work, that would be very appreciated ;-)

regards,
Hussayn


Jorge Uriarte wrote:
> 
> Hussayn; i like your proposal, and I'd  +1 !!
> 
> Thought it's quite an specific logic, it's much better than current
> behaviour IMHO.
> 
> I had an old issue somewhere (;) ) to also add a "mask" to the
> subject, in which to insert fields of the issue.
> 
> So in your examples, you'd have setted the mask in the module/issuetype
> to:
> 
>      "[SCARAB] ${issueId} ${action} ${title}"
> 
> but you'd easily configure it to:
> 
>      "[SCARAB] [${priority} ${issueId} ${ACTION} ${title}"
> 
> in my example I'm assuming ${ACTION} is a magic word for the result of
> your proposed "status_change" info, but I'm also letting the admin
> define the issue attributes that will also make their way into the
> subject if needed.
> 
> Just my two cents (needles to say your proposal is perfectly doable
> without my crazy ideas, so again, go on ;) )
> 
> _
> Jorge Uriarte Aretxaga
> http://www.gailen.es
> http://www.linkedin.com/in/jorgeuriarte
> 
> 
> 
> On Fri, May 29, 2009 at 10:49 AM, Hussayn Dabbous
> <[email protected]> wrote:
>> hi;
>>
>> currently the email subject looks like this:
>>
>> [<module>] Issue #<local_id> (<status_change>) <default_text>
>>
>> module: module name in uppercase
>> local_id: issue ID
>> status_change: empty, if the status has not changed, otherwise new status
>> default_text:
>>
>> i propose following changes:
>>
>> 1.) remove the String "Issue" (example see below)
>> 2.) make the "status_change" field more complex:
>>
>> if (status has changed)
>>       value of new status
>> elseif single change
>> {
>>    if (comment added)
>>       "new comment"
>>    else if (new attachment)
>>       "attachment"
>>    else if (personell change)
>>       "personell change"
>>    else if (relation change)
>>       "relation change"
>>    else
>>       "attribute change"
>> }
>> else
>> {
>>    "multiple changes"
>> }
>>
>> examples:
>> Let's say a new comment was added to an issue, then the email subject
>> might
>> look like this:
>>
>>    old: [SCARAB] Issue #2345 () proposing 2 changes in the email subject
>>    new: [SCARAB] #2345 (comment added) proposing 2 changes in the email
>> subject
>>
>> when multiple changes occur:
>>
>>    old: [SCARAB] Issue #2345 () proposing 2 changes in the email subject
>>    new: [SCARAB] #2345 (multiple changes) proposing 2 changes in the
>> email
>> subject
>>
>> when status changed to "closed" plus some comments have been added:
>>
>>    old: [SCARAB] Issue #2345 (closed) proposing 2 changes in the email
>> subject
>>    new: [SCARAB] #2345 (closed) proposing 2 changes in the email subject
>>
>> --
>> View this message in context:
>> http://www.nabble.com/proposing-2-changes-in-the-email-subject-tp23776443p23776443.html
>> Sent from the Scarab - User mailing list archive at Nabble.com.
>>
>> ------------------------------------------------------
>> http://scarab.tigris.org/ds/viewMessage.do?dsForumId=456&dsMessageId=2356692
>>
>> To unsubscribe from this discussion, e-mail:
>> [[email protected]].
>>
> 
> ------------------------------------------------------
> http://scarab.tigris.org/ds/viewMessage.do?dsForumId=456&dsMessageId=2357172
> 
> To unsubscribe from this discussion, e-mail:
> [[email protected]].
> 
> 

-- 
View this message in context: http://www.nabble.com/proposing-2-changes-in-the-email-subject-tp23776443p23877467.html
Sent from the Scarab - User mailing list archive at Nabble.com.

------------------------------------------------------
http://scarab.tigris.org/ds/viewMessage.do?dsForumId=456&dsMessageId=2359529

To unsubscribe from this discussion, e-mail: [[email protected]].