Re: [skinlf-dev] Follow-up on laf-plugin proposal
Kirill Grouchnikov <[email protected]> Fri, 24 Feb 2006 14:57:14 -0800 (PST)
| Newsgroups | gmane.comp.java.skinlf.devel |
|---|---|
| Message-ID | <[email protected]> |
--0-94293680-1140821834=:48562 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Hi, everybody Following your feedback, i have updated the laf-plugin classes with the following: 1. Moving nanoxml classes to org.jvnet.lafplugin in order to prevent possible clashes (as is in Skin). You should see no difference. 2. Uniting the below three function in one getDefaults as proposed by Fred 3. Adding sample usage codes to the main page [1] to show the recommended usage. The old version is still available at "dev 0.1" section of Documents & Files. The new one is under "dev 0.2". I have tested the new one with Substance (duh) and it works as expected. Let me know if you have any thoughts about the new (and simplified) API and if you have any problem running your LAFs with the new version. Regards Kirill [1] https://laf-plugin.dev.java.net "Robert F. Beeger" <[email protected]> wrote: Hi Kirill, Kirill Grouchnikov wrote: > The current separation follows approach in the Metal LAF (which may or > may not be a good choice depending on whether the particular LAF extends > Metal). I can easily add an additional function to the PluginManager > combining all three calls as you suggest. In the end it's all pushed into the same map. > > Another thing that you mention should most probably be added to the > signature of LafPlugin - the uninitialize (most probably making the > reset redundant). I think that's right. It constraints getDefaults to being called only once after a theme change, but that's OK for me. > > Erik, Robert, Pattrick - what do you think about uniting the mentioned > three functions into a single one? I think that's a good idea. Fortunately there aren't many plugins around yet. Otherwise this change of the public interface would be really a nightmare ;) Cheerio, Robert --------------------------------- Yahoo! Mail Use Photomail to share photos without annoying attachments. --0-94293680-1140821834=:48562 Content-Type: text/html; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Hi, everybody<br><br>Following your feedback, i have updated the laf-plugin classes with the following:<br>1. Moving nanoxml classes to org.jvnet.lafplugin in order to prevent possible clashes (as is in Skin). You should see no difference.<br>2. Uniting the below three function in one getDefaults as proposed by Fred<br>3. Adding sample usage codes to the main page [1] to show the recommended usage.<br><br>The old version is still available at "dev 0.1" section of Documents & Files. The new one is under "dev 0.2". I have tested the new one with Substance (duh) and it works as expected. Let me know if you have any thoughts about the new (and simplified) API and if you have any problem running your LAFs with the new version.<br><br>Regards<br>Kirill<br><br>[1] https://laf-plugin.dev.java.net<br><br><b><i>"Robert F. Beeger" <[email protected]></i></b> wrote:<blockquote class="replb q" style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"> Hi Kirill,<br>Kirill Grouchnikov wrote:<br> > The current separation follows approach in the Metal LAF (which may or<br> > may not be a good choice depending on whether the particular LAF extends<br> > Metal). I can easily add an additional function to the PluginManager<br> > combining all three calls as you suggest.<br>In the end it's all pushed into the same map.<br><br> ><br> > Another thing that you mention should most probably be added to the<br> > signature of LafPlugin - the uninitialize (most probably making the<br> > reset redundant).<br>I think that's right. It constraints getDefaults to being called only <br>once after a theme change, but that's OK for me.<br><br> ><br> > Erik, Robert, Pattrick - what do you think about uniting the mentioned<br> > three functions into a single one?<br>I think that's a good idea. Fortunately there aren't many plug ins around <br>yet. Otherwise this change of the public interface would be really a <br>nightmare ;)<br><br>Cheerio,<br> Robert<br></blockquote><br><p> <hr size=1> Yahoo! Mail<br> <a href="http://pa.yahoo.com/*http://us.rd.yahoo.com/evt=38867/*http://photomail.mail.yahoo.com">Use Photomail</a> to share photos without annoying attachments. --0-94293680-1140821834=:48562--