Re: Suggestions
"Goldsack, Patrick" <[email protected]> Thu, 6 Jul 2006 17:44:13 +0100
| Newsgroups | gmane.comp.java.smartfrog.devel |
|---|---|
| Message-ID | <[email protected]> |
Point 1) no reason that I can think of, so we should probably put that right Point 2) Parallel is capable of asynch deployment (but it no longer guarantees deploy before start between sub-components as the threads invoke sfCreateChild), and the termination handling is different to that of Compound. Please do send us a patch. Patrick -----Original Message----- From: smartfrog-developer-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:smartfrog-developer-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Olivier Pernet Sent: 06 July 2006 16:27 To: Smartfrog-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Subject: [Smartfrog-developer] Suggestions Hello again, I have a few suggestions/questions about the SmartFrog code : - Why is sfTerminateWith(TerminationRecord) public ? It's not declared in the Prim interface, and serves as a template method in PrimImpl (AFAIK). So, shouldn't it be protected ? - Compound can terminate its children asychronously, but can't deploy or start them the same way. Is there a Compound implementation that does this ? If not (I looked around, it seems so), I can implement one, but I'd like to make an AbstractInvokerThread that your TerminatorThread would extend, as well as my (future) DeployerThread and StarterThread (don't like duplicated code :) ). Should I do that and send a patch ? -- Olivier Pernet Summer Student - CERN Openlab We are the knights who say echo '16i[q]sa[ln0=aln100%Pln100/snlbx]sbA0D4D465452snlbxq'|dc Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Smartfrog-developer mailing list Smartfrog-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/smartfrog-developer Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642