Re: LoggerStore

Peter Donald <peter-4lf8KW9E9MLMqX/[email protected]>
Newsgroups gmane.comp.java.spice.devel
Message-ID <[email protected]>
Hi,

Don't have your last email here but I just went through the changes and I 
like. One thing you brought up was naming. I still prefer 
ExcaliburLoggerStore and ExcaliburLoggerStoreFactory because that avoids any 
future naming problems. 

It would be useful to gradually move back some Excalibur logging stuff to 
LogKit. If that was to happen then we would have a name clashe because we 
would want to name that LogKitLoggerStore if you know what I mean?

Also I changed it so that you don't upcast to a DefaultContext in the 
SimpleLoggerStoreFactory as that violates Avalon contracts. If you don't 
specify a context it will create one with current working dir added.

Also - what do you think of allowing the user to specify a classname of 
LoggerManager as a property that the LogKitLoggerStoreFactory will use if 
there is not already a LoggerManager in config. It will basically try to 
instantiate an instance of class using no arg constructor. Like?

-- 
Cheers,

Peter Donald
*------------------------------------------------------*
| "Nearly all men can stand adversity, but if you want |
| to test a man's character, give him power."          |
|       -Abraham Lincoln                               |
*------------------------------------------------------*



-------------------------------------------------------
This SF.net email is sponsored by: eBay
Get office equipment for less on eBay!
http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.