Re: stderr_printf patch
Chris Pickett <[email protected]>
| Newsgroups | gmane.comp.java.vm.sablevm.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, Can we commit this, or is there a problem? It might need fixing if more printf's were added since I did it. Chris Chris Pickett wrote: > Hi, > > This patch makes SableVM put all VM messages on stderr. It is useful > for doing diffs on benchmark output between VM's, and for separating > error and log messages from Java output. > > A better solution would see 4 output streams: > > java_stdout > java_stderr > sablevm_stdout > sablevm_stderr > > and the use of properties to select where they go (the user could > specify either file descriptors or file names). > > However, Greg and I discussed that we want the default to be: > > stream descriptor > ========================= > java_stdout 1 > java_stderr 2 > sablevm_stdout 2 > sablevm_stderr 2 > > and this patch gives that behaviour. It is definitely better than what > was there before, a mix of stderr and stdout all over the place. > > I just did s/stdout/stderr/g on all files, and killed an unused > _svmf_printf declaration in util.h. > > svn diff -r3117:3118 > svn+ssh://svn.sablevm.org/public/developers/chris/sandbox/stderr_printf/ > > Cheers, > Chris > > P.S. I have some other cleaning-up kind of things to do (elimination of > cloned code primarily). I will make different patches for them. >