Re: staging is broken (again) with --enable-debugging-features on x86_64

Chris Pickett <[email protected]>
Newsgroups gmane.comp.java.vm.sablevm.devel
Message-ID <[email protected]>
Chris Pickett wrote:
> Hi,
> 
> I looked at system.c but couldn't see what the problem was (the pword 
> parameter is indeed used for __ia64__, but maybe there's a problem 
> because it's an AMD Opteron machine).

Sorry, __ia64__ is not __x86_64__.

> In file included from libsablevm.c:80:
> system.c: In function `_svmf_iflush':
> system.c:37: warning: unused parameter `pword'
> make[5]: *** [libsablevm.lo] Error 1

The problem is that the __clear_cache call is only included if the 
inlined threading engine is used.  IMO, the check for 
SABLEVM_INLINED_THREADED_INTERPRETER should be moved outside of 
_svmf_iflush() to wherever _svmf_iflush() is called -- what if somebody 
else besides the inlined engine ever wants to call it?

Chris
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.