Re: staging is broken (again) with --enable-debugging-features on x86_64

Chris Pickett wrote:
> Chris Pickett wrote:
> 
>> Hi,
>>
>> I looked at system.c but couldn't see what the problem was (the pword 
>> parameter is indeed used for __ia64__, but maybe there's a problem 
>> because it's an AMD Opteron machine).
> 
> 
> Sorry, __ia64__ is not __x86_64__.
> 
>> In file included from libsablevm.c:80:
>> system.c: In function `_svmf_iflush':
>> system.c:37: warning: unused parameter `pword'
>> make[5]: *** [libsablevm.lo] Error 1
> 
> 
> The problem is that the __clear_cache call is only included if the 
> inlined threading engine is used.  IMO, the check for 
> SABLEVM_INLINED_THREADED_INTERPRETER should be moved outside of 
> _svmf_iflush() to wherever _svmf_iflush() is called -- what if somebody 
> else besides the inlined engine ever wants to call it?

_svmf_iflush() is only called from prepare_code.c, already inside a 
check for the SABLEVM_INLINED_THREADED_INTERPRETER.

I think I have the right fix:

svn diff -r3179:3181 
svn+ssh://svn.sablevm.org/public/developers/chris/sandbox/verbose_methods

Note that pword is now cast to a (char *) from an (_svmt_word *) -- if 
this doing so always makes the new (char *) point to the first byte of 
the word, then it is safe.

Chris