[XDoclet-JIRA] Assigned: (XDT-1477) havingClassTag attribute for deploymentdescriptor task

Message:

   The following issue has been re-assigned.

   Assignee: Matthias Germann (mailto:[email protected])
---------------------------------------------------------------------
View the issue:
  http://opensource.atlassian.com/projects/xdoclet/browse/XDT-1477

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XDT-1477
    Summary: havingClassTag attribute for deploymentdescriptor task
       Type: Bug

     Status: Closed
   Priority: Major
 Resolution: DUPLICATE

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: XDoclet
 Components: 
             EJB Module
   Versions:
             1.2.3

   Assignee: Matthias Germann
   Reporter: R. Lemos

    Created: Thu, 21 Jul 2005 7:22 AM
    Updated: Mon, 1 Aug 2005 7:39 AM

Description:
The 'deploymentdescriptor' task was ignoring the 'havingClassTag' attribute (XDT-943), but that was thankfully corrected.

But I think you missed the EjbTagsHandler#forAllBeans, as it still runs for all beans, unaware of the 'havingClassTag' attribute. The problem here appears in the 'transactions' part (and maybe others as well) of 'deployment descriptor': all @ejb.transaction attributes are still written to a deployment descriptor, despite of being told not to do so (by means of havingClassTag attribute).

Consider applying the following patch, which still passes all unit-tests and yet generate sane deployment descriptors. I can't assert it doesn't have side-effects, since I don't know the inner details of xdoclet; I can only assert 'It works for me'. Let me know if I can help any further.

Thanks in advance,

R. Lemos


-------------- cut here -------------
diff -u -r1.30 EjbTagsHandler.java
--- xdoclet/modules/ejb/src/xdoclet/modules/ejb/EjbTagsHandler.java 6 Apr 2005 21:50:35 -0000 1.30
+++ xdoclet/modules/ejb/src/xdoclet/modules/ejb/EjbTagsHandler.java 21 Jul 2005 11:35:53 -0000
@@ -617,6 +617,10 @@
                 continue;
             }

+ if (!hasHavingClassTag(getCurrentClass())) {
+ continue;
+ }
+
             if (EntityTagsHandler.isEntity(getCurrentClass()) || SessionTagsHandler.isSession(getCurrentClass()) ||
                 MdbTagsHandler.isMessageDriven(getCurrentClass())) {
                 currentEjbClass = getCurrentClass();
-------------- cut here -------------

PS: this description duplicates my comment on XDT-943 as I was unable to reopen that issue.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/xdoclet/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click