[qt/qt-creator/qt-creator]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qt-creator/qt-creator Pushed by mirror-service into branch '20.0'. Changed from 2f305d63f91a48a0a5e0b5503cb8b9311ead1407 to b1b435639c4c96ece103a564ebce5ed1954d4627 Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit a9cb0b092742dc9d21afae962e6c7e05f574fef2 by hjk on 22/07/2026 at 06:39.. Utils: Do not assert when opening an unreadable remote file FSEngineImpl::open() soft-asserted via QTC_ASSERT_RESULT when fileContents() failed on the read path. Reading can legitimately fail at runtime - e.g. a dangling symlink that the cached file info still reports as existing, or insufficient permissions - which is not a programming error. Fail the open gracefully (return false) instead. Assisted-by: Claude Code Change-Id: Iaeae4910c9cf1ed1836fe947e60dd8b81bc346c1 (cherry picked from commit c4fb0d77a7e7d1665cccfde4de29bf05bd9041b2) Reviewed-by: Eike Ziller <[email protected]> https://invent.kde.org/qt/qt-creator/qt-creator/-/commit/a9cb0b092742dc9d21afae962e6c7e05f574fef2 Git commit 2f7e2615fd9683d3d56a37a66e61da1aa188a0fa by hjk on 22/07/2026 at 06:39.. Debugger: Fix crash when stopping with a memory editor open A memory editor (as opposed to a separate memory view) is a BinEditor service that is also an IEditor and is handed to the EditorManager via addEditor(), so the EditorManager owns its lifetime. ~MemoryAgent still deleted that service directly, which left a dangling editor registered with the EditorManager and crashed shortly after the debugger stopped. The editor is already taken care of elsewhere: on debugger exit DebuggerEnginePrivate::cleanupViews() closes or keeps it depending on the "close buffers on exit" settings, and MemoryAgent::setFinished() clears the handlers that reference the engine. So ~MemoryAgent must not touch an editor at all; only a separate view is owned by the agent and deleted here. Assisted-by: Claude Code Change-Id: I372bf0caf0d2e3f543f3a830b639eb73de6d49bc (cherry picked from commit f397a9475bb321d9f1bfd250951f340a3a2f2efa) Reviewed-by: Eike Ziller <[email protected]> https://invent.kde.org/qt/qt-creator/qt-creator/-/commit/2f7e2615fd9683d3d56a37a66e61da1aa188a0fa Git commit 8327117cfff288f7d8bac12d0deebe53578cc0a4 by hjk on 22/07/2026 at 06:40.. Debugger: Fix use-after-free in DebuggerEngine::gotoLocation() DebuggerEngine::gotoLocation() calls EditorManager::openEditor(), which spins a local event loop. If the debug session finishes during that window, the engine is torn down (qDeleteAll(m_engines) -> ~DebuggerEngine -> delete d). The code then dereferenced 'd' and 'this' (m_locationMark, m_breakHandler, m_watchHandler, displayName()), crashing on freed memory. This is the same reentrancy hazard fixed for BreakHandler::gotoLocation() in ef7ababba142ef83267d65cee3c49aa621e1db0e, reachable here via the BreakpointByAddress branch of that function. Guard the engine with a local QPointer across the re-entrant openEditor() call and bail out if it was destroyed, so nothing touches freed memory afterwards. Assisted-by: Claude Code Change-Id: I508c337305967bbef306f5b2b0736161ac6127c4 Reviewed-by: Christian Stenger <[email protected]> (cherry picked from commit 2e6babffbb48ad8818d98b79fc5e4564fe62b4b2) Reviewed-by: Eike Ziller <[email protected]> https://invent.kde.org/qt/qt-creator/qt-creator/-/commit/8327117cfff288f7d8bac12d0deebe53578cc0a4 Git commit b1b435639c4c96ece103a564ebce5ed1954d4627 by Cristian Adam on 22/07/2026 at 08:31.. CMakeProjectManager: Add build preset vendor extension support Read Qt Creator-specific make step settings from the build preset vendor extension (qt.io/QtCreator/1.0). This allows staging, iOS provisioning, clear system environment to be specified in CMakePresets.json/CMakeUserPresets.json. Also document the new build preset vendor keys. Fixes: QTCREATORBUG-34800 Change-Id: I1384ff227e056a87c80fb1ac974dc0bcdbbb35f4 Reviewed-by: Eike Ziller <[email protected]> https://invent.kde.org/qt/qt-creator/qt-creator/-/commit/b1b435639c4c96ece103a564ebce5ed1954d4627