[plasma/plasma-workspace] libnotificationmanager: libnotificationmanager: Return empty icon name in jobs model
Kai Uwe Broulik <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit cf16ace940423672eb9ab63b2f0cc1cf568deb4b by Kai Uwe Broulik.
Committed on 25/07/2026 at 05:22.
Pushed by broulik into branch 'master'.
libnotificationmanager: Return empty icon name in jobs model
There is no job icon and the one at the end comes from JobDetails
and the FileInfo stuff, not the model.
This case was forgotten in the original fix for Qt 6.11.1 and
resulted in an "unknown" icon showing behind the job icon.
Most of the time this wasn't noticeable because it had the same
"file shape" of the finished icon, but was visible after e.g.
copying an image.
Amends commit faf0e944
BUG: 522846
M +1 -0 libnotificationmanager/jobsmodel.cpp
https://invent.kde.org/plasma/plasma-workspace/-/commit/cf16ace940423672eb9ab63b2f0cc1cf568deb4b
diff --git a/libnotificationmanager/jobsmodel.cpp b/libnotificationmanager/jobsmodel.cpp
index 459a7c639d..32d4d1c898 100644
--- a/libnotificationmanager/jobsmodel.cpp
+++ b/libnotificationmanager/jobsmodel.cpp
@@ -149,6 +149,7 @@ QVariant JobsModel::data(const QModelIndex &index, int role) const
// Qt doesn't like the model not returning anything, for example
// casting it to "undefined" as a string (when put in a required property string)
// blowing up in client code left and right.
+ case Notifications::IconNameRole:
case Notifications::NotifyRcNameRole:
case Notifications::OriginNameRole:
case Notifications::DefaultActionLabelRole: