[qt/qtqa/gerrit]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]> Tue, 4 Aug 2026 18:15:46 +0000 (UTC)
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qtqa/gerrit Pushed by mirror-service into branch 'upstream/master'. Changed from d5d1594f79cb17c77338bedee567d86104238aa3 to 4fe2c7902aa57bcecb7d5ab74bbbed37c0724552 Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit 498baf847cab2997a473585f0a3f7a18644faac6 by Hitesh Chaudhari on 28/07/2026 at 13:01.. Fix label migration for branch patterns in submit requirements Current situation: The label migration API converts labels with function = MaxWithBlock into submit requirements. However, branch patterns are currently migrated by embedding the original branch value directly into the applicableIf expression. For example: [label "rest-authz"] branch = refs/heads/* function = MaxWithBlock was migrated to: [submit-requirement "rest-authz"] applicableIf = branch:\\\"refs/heads/*\\\" Motivation: This is not a valid Gerrit query expression. While refs/heads/* is a valid label branch pattern, the branch: operator in submit requirement expressions expects either an exact branch name or a regular expression. Fix: This change converts branch patterns during migration as follows: refs/heads/master -> branch:"refs/heads/master" refs/heads/* -> branch:^refs/heads/.* refs/* -> branch:^refs/.* ^refs/heads/.* -> branch:^refs/heads/.* refs/heads/hi\"ch -> branch:"refs/heads/hi\"ch" refs/heads/hi#ch -> branch:"refs/heads/hi#ch" As a result, the generated applicableIf expressions are valid and preserve the semantics of the original label branch restrictions. NOTE: After migration, When Jgit persists the data into config, it is persisted with escaping characters. E.g. [label "rest-authz-hash"] branch = "refs/heads/hi#ch" -> persisted after migration to [submit-requirement "rest-authz-hash"] applicableIf = branch:\"refs/heads/hi\\\"ch\" But during runtime, it is interpreted as `branch:"refs/heads/hi\"ch"` Change-Id: I80aaa87019a9e8412be5e26949cd150c9ffe6515 Release-Notes: Fix label migration for branch patterns in submit requirements https://invent.kde.org/qt/qtqa/gerrit/-/commit/498baf847cab2997a473585f0a3f7a18644faac6 Git commit e46d5c6612c21c81ddb358d1952f8f13624f2b47 by Erik Flodin on 04/08/2026 at 06:14.. Use validation message enum for receive commits warnings This will then output "WARNING" instead of "warning" and align with other validators. To further align the output with branch commit validators use "commit" prefix before abbreviated commit hash. Release-Notes: Change commit validation output format Change-Id: I1c991f0edf8d75b9950a27c1b0efea0855c59e34 https://invent.kde.org/qt/qtqa/gerrit/-/commit/e46d5c6612c21c81ddb358d1952f8f13624f2b47 Git commit 8f2afbfab920cfb1aa895891903ab359dcb4da34 by Gerrit Code Review (on behalf of Hitesh Chaudhari) on 04/08/2026 at 14:48.. Merge "Fix label migration for branch patterns in submit requirements" https://invent.kde.org/qt/qtqa/gerrit/-/commit/8f2afbfab920cfb1aa895891903ab359dcb4da34 Git commit 4fe2c7902aa57bcecb7d5ab74bbbed37c0724552 by Gerrit Code Review (on behalf of Erik Flodin) on 04/08/2026 at 16:55.. Merge "Use validation message enum for receive commits warnings" https://invent.kde.org/qt/qtqa/gerrit/-/commit/4fe2c7902aa57bcecb7d5ab74bbbed37c0724552