[qt/qtqa/gerrit]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]> Tue, 4 Aug 2026 18:15:46 +0000 (UTC)
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qtqa/gerrit Pushed by mirror-service into branch 'upstream/stable-3.13'. Changed from 500db78ce454182269efa9cce0cd7fa3e1f9d344 to d5ee47efc90fc6bfce5e880b0cd6fe5c7d73e30d Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit d5ee47efc90fc6bfce5e880b0cd6fe5c7d73e30d by Orgad Shaneh on 04/08/2026 at 16:30.. UI: Keep edit mode and the base when changing the patch range Changing the patch range while in edit mode silently dropped the edit mode, because <gr-file-list-header> did not pass `edit` on to `createChangeUrl()`. And even with `edit` preserved the resulting URL was not routable: the CHANGE_EDIT pattern accepted a single positive patchset only, so neither a patch range nor a merge parent could be expressed. Editing a merge commit with a parent as the base was therefore impossible. Let CHANGE_EDIT accept the same range expression as CHANGE, read the base in `handleChangeEditRoute()`, and keep the base when entering and leaving edit mode. Entering edit mode uses the view model value, so that a URL without a base stays without one. Edit mode is only kept when the patchset itself stays the same, i.e. when just the base changes. A change edit is based on one specific patchset: modifications always go into the existing edit, no matter which patchset is being displayed, and only an edit based on the current patchset can be published. So following along to another patchset would only pretend that the edit does. Release-Notes: Fixed losing edit mode when changing the diff base. Change-Id: Ie77d3f3a1b2ea29dd867bf49380db149cc4a22dd https://invent.kde.org/qt/qtqa/gerrit/-/commit/d5ee47efc90fc6bfce5e880b0cd6fe5c7d73e30d