[documentation/develop-kde-org] content/docs/getting-started/kirigami/introduction-listviews: Kirigami: Remove layout.fillHeight to match the code in the earlier sections
Nate Graham <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit 76d5f1e67b31fd8866b067b30892f288d78d8874 by Nate Graham, on behalf of Michael Rostom.
Committed on 05/08/2026 at 21:15.
Pushed by ngraham into branch 'master'.
Kirigami: Remove layout.fillHeight to match the code in the earlier sections
Removed `Layout.fillHeight` from the heading items in the Inner Components section,
as it fills height by default. Also changed `i18n` to `i18nc` to encourage
contributors to add translation context.
M +1 -1 content/docs/getting-started/kirigami/introduction-listviews/Main.qml
M +2 -3 content/docs/getting-started/kirigami/introduction-listviews/index.md
https://invent.kde.org/documentation/develop-kde-org/-/commit/76d5f1e67b31fd8866b067b30892f288d78d8874
diff --git a/content/docs/getting-started/kirigami/introduction-listviews/Main.qml b/content/docs/getting-started/kirigami/introduction-listviews/Main.qml
index fbda6045b..d06edcb90 100644
--- a/content/docs/getting-started/kirigami/introduction-listviews/Main.qml
+++ b/content/docs/getting-started/kirigami/introduction-listviews/Main.qml
@@ -70,7 +70,7 @@ Kirigami.ApplicationWindow {
Layout.alignment: Qt.AlignRight
// Column spanning within grid layout (vertically in this case)
Layout.columnSpan: 2
- text: i18n("Edit")
+ text: i18nc("@action:button","Edit")
//onClicked: to be done...
}
}
diff --git a/content/docs/getting-started/kirigami/introduction-listviews/index.md b/content/docs/getting-started/kirigami/introduction-listviews/index.md
index aa8ad73f6..0ea708c50 100644
--- a/content/docs/getting-started/kirigami/introduction-listviews/index.md
+++ b/content/docs/getting-started/kirigami/introduction-listviews/index.md
@@ -125,7 +125,7 @@ Kirigami.ApplicationWindow {
Controls.Button {
Layout.alignment: Qt.AlignRight
Layout.columnSpan: 2
- text: i18n("Edit")
+ text: i18nc("@action:button","Edit")
// onClicked: to be done... soon!
}
}
@@ -213,7 +213,6 @@ We could just create three labels within our delegate component and call it a da
GridLayout {
// ...
Kirigami.Heading {
- Layout.fillHeight: true
level: 1
text: date
}
@@ -241,7 +240,7 @@ GridLayout {
Controls.Button {
Layout.alignment: Qt.AlignRight
Layout.columnSpan: 2
- text: i18n("Edit")
+ text: i18nc("@action:button","Edit")
}
}
```