[frameworks/kio] src/widgets: kfileitemactions: remove dead code
Antti Savolainen <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit 74e9dd75bba238ae0e4dcaf1a9a6366e1e137bc6 by Antti Savolainen.
Committed on 05/08/2026 at 22:44.
Pushed by asavolainen into branch 'master'.
kfileitemactions: remove dead code
M +6 -14 src/widgets/kfileitemactions.cpp
https://invent.kde.org/frameworks/kio/-/commit/74e9dd75bba238ae0e4dcaf1a9a6366e1e137bc6
diff --git a/src/widgets/kfileitemactions.cpp b/src/widgets/kfileitemactions.cpp
index b1446eff47..662abd7907 100644
--- a/src/widgets/kfileitemactions.cpp
+++ b/src/widgets/kfileitemactions.cpp
@@ -602,20 +602,16 @@ void KFileItemActionsPrivate::addServiceActionsTo(QMenu *mainMenuHolder,
}
}
- int userItemCount = 0;
- userItemCount += additionalActions.count();
for (QAction *action : additionalActions) {
actionsMenuHolder->addAction(action);
}
- userItemCount += insertServicesSubmenus(s.userPrioritySubmenus, actionsMenuHolder);
- userItemCount += insertServices(s.userPriority, actionsMenuHolder);
- userItemCount += insertServicesSubmenus(s.userSubmenus, actionsMenuHolder);
- userItemCount += insertServices(s.user, actionsMenuHolder);
+ insertServicesSubmenus(s.userPrioritySubmenus, actionsMenuHolder);
+ insertServices(s.userPriority, actionsMenuHolder);
+ insertServicesSubmenus(s.userSubmenus, actionsMenuHolder);
+ insertServices(s.user, actionsMenuHolder);
- userItemCount += insertServicesSubmenus(s.userToplevelSubmenus, mainMenuHolder);
- userItemCount += insertServices(s.userToplevel, mainMenuHolder);
-
- // return {userItemCount, actionMenu};
+ insertServicesSubmenus(s.userToplevelSubmenus, mainMenuHolder);
+ insertServices(s.userToplevel, mainMenuHolder);
}
void KFileItemActionsPrivate::addPluginActionsTo(QMenu *mainMenuHolder, QMenu *actionsMenuHolder, const QStringList &excludeList)
@@ -625,8 +621,6 @@ void KFileItemActionsPrivate::addPluginActionsTo(QMenu *mainMenuHolder, QMenu *a
commonMimeType = QStringLiteral("application/octet-stream");
}
- int itemCount = 0;
-
const KConfigGroup showGroup = m_config.group(QStringLiteral("Show"));
const QMimeDatabase db;
@@ -659,7 +653,6 @@ void KFileItemActionsPrivate::addPluginActionsTo(QMenu *mainMenuHolder, QMenu *a
if (abstractPlugin) {
connect(abstractPlugin, &KAbstractFileItemActionPlugin::error, q, &KFileItemActions::error);
const QList<QAction *> actions = abstractPlugin->actions(m_props, m_parentWidget);
- itemCount += actions.count();
if (jsonMetadata.value(QStringLiteral("X-KDE-Show-In-Submenu"), false)) {
if (pluginId == QLatin1String("setfoldericonitemaction")) {
iconAction = actions;
@@ -672,7 +665,6 @@ void KFileItemActionsPrivate::addPluginActionsTo(QMenu *mainMenuHolder, QMenu *a
}
}
actionsMenuHolder->addActions(iconAction);
- // return itemCount;
}
KService::List KFileItemActionsPrivate::associatedApplications(const QStringList &mimeTypeList, const QStringList &excludedDesktopEntryNames)