Re: Fixing krazy2 issues

2009/1/21 Matthew Woehlke <[email protected]>:
> Thomas Richard wrote:
>> in response to the Kourse that's currently running on the message
>> boards i've prepared some patches to fix krazy2 issues in
>> kdeaccesibilty. You can find them in the attachement. Please take a
>> good look before committing because these are my first patches.
>
> What about these comments instead, for kmag?
>
> Index: kmag.cpp
> ===================================================================
> --- kmag.cpp    (revision 913891)
> +++ kmag.cpp    (working copy)
> @@ -91,7 +91,7 @@
>    fpsArray.push_back(15); // high
>    fpsArray.push_back(25); // very high
>
> -  colorArrayString << i18n("&Normal") << i18n("&Protanopia") <<
> i18n("&Deuteranopia") << i18n("&Tritanopia") << i18n("&Achromatopsia");
> +  colorArrayString << i18nc("No color-blindness simulation, i.e.
> 'normal' vision", "&Normal") << i18n("&Protanopia") <<
> i18n("&Deuteranopia") << i18n("&Tritanopia") << i18n("&Achromatopsia");
>
>    colorArray.push_back(0);
>    colorArray.push_back(1);
> @@ -253,7 +253,7 @@
>    m_pFPSBox->setWhatsThis(i18n("Select the refresh rate. The higher
> the rate, the more computing power (CPU) will be needed."));
>    m_pFPSBox->setToolTip(i18n("Refresh rate"));
>
> -  m_pColorBox = new KSelectAction(i18n("&Color"),this);
> +  m_pColorBox = new KSelectAction(i18nc("Color-blindness simulation
> mode", "&Color"),this);
>    actionCollection()->addAction("color_mode", m_pColorBox);
>    m_pColorBox->setItems(colorArrayString);
>    m_pColorBox->setWhatsThis(i18n("Select a mode to simulate various
> types of color-blindness."));
> @@ -664,7 +664,7 @@
>      refreshSwitch->setToolTip(i18n("Click to stop window update"));
>    } else {
>      refreshSwitch->setIcon(KIcon("reload.png"));
> -    refreshSwitch->setText(i18n("Start"));
> +    refreshSwitch->setText(i18nc("Start updating the window", "Start"));
>      refreshSwitch->setToolTip(i18n("Click to start window update"));
>    }
>  }
> ===================================================================
>
> --
> Matthew
> Please do not quote my e-mail address unobfuscated in message bodies.
> --
> "Inches: An antiquated measurement unit still in use in certain
> backwards countries with incredibly low-cost computer equipment."
>   -- groff documentation
>
> _______________________________________________
> kde-accessibility mailing list
> [email protected]
> https://mail.kde.org/mailman/listinfo/kde-accessibility
>

Thanks for your response Matthew. I'll adjust those.

I expected to get a little more feedback though. I'd love to help kde but not
if my work ends up in the dumpster :)

Greetings
Thomas