Re: KDE review request: KDominate

--000000000000c0c233064defedf3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

The following checkboxes still need ticking :)

- A screenshot in product-screenshots
- A bugs.kde.org product (file a sysadmin ticket)

These two are done (but I think I shouldn't tick the boxes myself, right?).

- Check the code with some sanity tools like clazy or clang-tidy, if not
already done as part of CI runs

Not automated in the CI but I ran clazy a few times during development and
fixed the findings.

- Passing KDE neon build

No idea what needs to be done here.

https://invent.kde.org/games/kdominate/-/issues/1


On Sun, Mar 1, 2026 at 2:31=E2=80=AFAM Albert Vaca Cintora <albertvaka@gmai=
l.com>
wrote:

> The repo has now been moved to https://invent.kde.org/games/kdominate so
> the review can proceed.
>
> On Fri, Feb 27, 2026 at 9:20=E2=80=AFPM Albert Vaca Cintora <albertvaka@g=
mail.com>
> wrote:
>
>> Hi,
>>
>> I wrote KDominate, a simple desktop game that I would like to make part
>> of KDE Games.
>>
>> I reused the UI from KJumpingCube to keep the same look and feel as othe=
r
>> KDE Games, although I modernized the code a bit (KJumpingCube was made i=
n
>> 1999!). The README explains both how to play and how the code is
>> structured, so it might be useful to read.
>>
>> The gameplay is actually based on a shareware game for Windows 3.1 that =
I
>> was nostalgic about, maybe someone here even played the original :)
>>
>> * Source: https://invent.kde.org/albertvaka/kdominate
>> * Review checklist:
>> https://invent.kde.org/albertvaka/kdominate/-/issues/1
>>
>> Albert
>>
>>
>>

--000000000000c0c233064defedf3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>The following checkboxes still need ticking :)</div><=
div><br>- A screenshot in product-screenshots<br>- A <a href=3D"http://bugs=
.kde.org" target=3D"_blank">bugs.kde.org</a> product (file a sysadmin ticke=
t)<br><br>These two are done (but I think I shouldn&#39;t tick the boxes my=
self, right?).<br><br>- Check the code with some sanity tools like clazy or=
 clang-tidy, if not already done as part of CI runs</div><div><br></div><di=
v>Not automated in the CI but I ran clazy a few times during development an=
d fixed the findings.</div><div><br>- Passing KDE neon build<br><br>No idea=
 what needs to be done here.</div><div><br></div><div><a href=3D"https://in=
vent.kde.org/games/kdominate/-/issues/1" target=3D"_blank">https://invent.k=
de.org/games/kdominate/-/issues/1</a></div><div><br></div></div><br><div cl=
ass=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Mar 1, 20=
26 at 2:31=E2=80=AFAM Albert Vaca Cintora &lt;<a href=3D"mailto:albertvaka@=
gmail.com" target=3D"_blank">[email protected]</a>&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=
=3D"ltr">The repo has now been moved to <a href=3D"https://invent.kde.org/g=
ames/kdominate" target=3D"_blank">https://invent.kde.org/games/kdominate</a=
> so the review can proceed.</div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On Fri, Feb 27, 2026 at 9:20=E2=80=AFPM Alber=
t Vaca Cintora &lt;<a href=3D"mailto:[email protected]" target=3D"_blank=
">[email protected]</a>&gt; wrote:<br></div><blockquote class=3D"gmail_q=
uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2=
04);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div>Hi,</div><div>=
<br></div><div>I wrote KDominate, a simple desktop game that I would like t=
o make part of=C2=A0KDE Games.</div><div><br></div><div>I reused the UI fro=
m=C2=A0KJumpingCube to keep the same look and feel as other KDE Games, alth=
ough I modernized the code a bit (KJumpingCube was made in 1999!). The READ=
ME explains both how to play and=C2=A0how the code is structured, so it mig=
ht be useful to read.</div><div><div><br></div><div>The gameplay is actuall=
y based on a shareware game for Windows 3.1 that I was nostalgic about, may=
be someone here even played the original :)</div><br></div><div>* Source:=
=C2=A0<a href=3D"https://invent.kde.org/albertvaka/kdominate" target=3D"_bl=
ank">https://invent.kde.org/albertvaka/kdominate</a></div><div>*=C2=A0Revie=
w checklist:=C2=A0<a href=3D"https://invent.kde.org/albertvaka/kdominate/-/=
issues/1" target=3D"_blank">https://invent.kde.org/albertvaka/kdominate/-/i=
ssues/1</a></div><div><br></div><div></div><div>Albert</div><div><br></div>=
<div><br></div></div>
</div>
</blockquote></div></div>
</blockquote></div>

--000000000000c0c233064defedf3--