Re: KDE review request: KDominate
Akseli Lahtinen <[email protected]> Thu, 26 Mar 2026 20:34:16 +0200
| Newsgroups | gmane.comp.kde.devel.core |
|---|---|
| Message-ID | <2821226.mvXUDI8C0e@desktop> |
On Thursday 26 March 2026 18:31:55 Eastern European Standard Time Albert Va= ca Cintora wrote: > The following checkboxes still need ticking :) >=20 > - A screenshot in product-screenshots > - A bugs.kde.org product (file a sysadmin ticket) >=20 > These two are done (but I think I shouldn't tick the boxes myself, right?= ). >=20 > - Check the code with some sanity tools like clazy or clang-tidy, if not > already done as part of CI runs >=20 > Not automated in the CI but I ran clazy a few times during development and > fixed the findings. >=20 > - Passing KDE neon build >=20 > No idea what needs to be done here. >=20 > https://invent.kde.org/games/kdominate/-/issues/1 >=20 >=20 > On Sun, Mar 1, 2026 at 2:31=E2=80=AFAM Albert Vaca Cintora <albertvaka@gm= ail.com> > wrote: >=20 > > The repo has now been moved to https://invent.kde.org/games/kdominate so > > the review can proceed. > > > > On Fri, Feb 27, 2026 at 9:20=E2=80=AFPM Albert Vaca Cintora <albertvaka= @gmail.com> > > wrote: > > > >> Hi, > >> > >> I wrote KDominate, a simple desktop game that I would like to make part > >> of KDE Games. > >> > >> I reused the UI from KJumpingCube to keep the same look and feel as ot= her > >> KDE Games, although I modernized the code a bit (KJumpingCube was made= in > >> 1999!). The README explains both how to play and how the code is > >> structured, so it might be useful to read. > >> > >> The gameplay is actually based on a shareware game for Windows 3.1 tha= t I > >> was nostalgic about, maybe someone here even played the original :) > >> > >> * Source: https://invent.kde.org/albertvaka/kdominate > >> * Review checklist: > >> https://invent.kde.org/albertvaka/kdominate/-/issues/1 > >> > >> Albert > >> > >> > >> >=20 Just as an aside, some screenshots/videos in the readme could be nice :) Best regards, =2D Akseli