Re: KDE review request: KDominate

El dijous, 26 de mar=C3=A7 del 2026, a les 17:31:55 (Hora d=E2=80=99estiu d=
=E2=80=99Europa=20
central), Albert Vaca Cintora va escriure:
> The following checkboxes still need ticking :)
>=20
> - A screenshot in product-screenshots
> - A bugs.kde.org product (file a sysadmin ticket)
>=20
> These two are done (but I think I shouldn't tick the boxes myself, right?=
).

=46or the ones that are factual, i think you can. Either there is or there =
is=20
not a screenshot/product. I have done it for you anyway.

>=20
> - Check the code with some sanity tools like clazy or clang-tidy, if not
> already done as part of CI runs
>=20
> Not automated in the CI but I ran clazy a few times during development and
> fixed the findings.

I also checked this one.

>=20
> - Passing KDE neon build
>=20
> No idea what needs to be done here.
>=20
> https://invent.kde.org/games/kdominate/-/issues/1

Everything is checked now.

Cheers,
  Albert


>=20
> On Sun, Mar 1, 2026 at 2:31=E2=80=AFAM Albert Vaca Cintora <albertvaka@gm=
ail.com>
>=20
> wrote:
> > The repo has now been moved to https://invent.kde.org/games/kdominate so
> > the review can proceed.
> >=20
> > On Fri, Feb 27, 2026 at 9:20=E2=80=AFPM Albert Vaca Cintora <albertvaka=
@gmail.com>
> >=20
> > wrote:
> >> Hi,
> >>=20
> >> I wrote KDominate, a simple desktop game that I would like to make part
> >> of KDE Games.
> >>=20
> >> I reused the UI from KJumpingCube to keep the same look and feel as ot=
her
> >> KDE Games, although I modernized the code a bit (KJumpingCube was made=
 in
> >> 1999!). The README explains both how to play and how the code is
> >> structured, so it might be useful to read.
> >>=20
> >> The gameplay is actually based on a shareware game for Windows 3.1 tha=
t I
> >> was nostalgic about, maybe someone here even played the original :)
> >>=20
> >> * Source: https://invent.kde.org/albertvaka/kdominate
> >> * Review checklist:
> >> https://invent.kde.org/albertvaka/kdominate/-/issues/1
> >>=20
> >> Albert