Re: KDE review request: KDominate
Albert Vaca Cintora <[email protected]> Tue, 7 Apr 2026 16:19:55 +0200
| Newsgroups | gmane.comp.kde.devel.core |
|---|---|
| Message-ID | <CAAQViEv7qLxQ1s7wsejHAO0tuE0-0yvrypCiAdivkg4CUcx4Lw@mail.gmail.com> |
--000000000000d87349064edf7bf0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =F0=9F=A5=B3 What are the next steps, now? The wiki mentions the case where= the project is not accepted (*After two months in KDE Review the repo should be moved back to playground or moved to unmaintained*) but says nothing about the case the project is accepted. On Mon, Apr 6, 2026 at 4:13=E2=80=AFPM Albert Astals Cid <[email protected]> wr= ote: > El dijous, 26 de mar=C3=A7 del 2026, a les 17:31:55 (Hora d=E2=80=99estiu= d=E2=80=99Europa > central), Albert Vaca Cintora va escriure: > > The following checkboxes still need ticking :) > > > > - A screenshot in product-screenshots > > - A bugs.kde.org product (file a sysadmin ticket) > > > > These two are done (but I think I shouldn't tick the boxes myself, > right?). > > For the ones that are factual, i think you can. Either there is or there > is > not a screenshot/product. I have done it for you anyway. > > > > > - Check the code with some sanity tools like clazy or clang-tidy, if no= t > > already done as part of CI runs > > > > Not automated in the CI but I ran clazy a few times during development > and > > fixed the findings. > > I also checked this one. > > > > > - Passing KDE neon build > > > > No idea what needs to be done here. > > > > https://invent.kde.org/games/kdominate/-/issues/1 > > Everything is checked now. > > Cheers, > Albert > > > > > > On Sun, Mar 1, 2026 at 2:31=E2=80=AFAM Albert Vaca Cintora <albertvaka@= gmail.com > > > > > > wrote: > > > The repo has now been moved to https://invent.kde.org/games/kdominate > so > > > the review can proceed. > > > > > > On Fri, Feb 27, 2026 at 9:20=E2=80=AFPM Albert Vaca Cintora < > [email protected]> > > > > > > wrote: > > >> Hi, > > >> > > >> I wrote KDominate, a simple desktop game that I would like to make > part > > >> of KDE Games. > > >> > > >> I reused the UI from KJumpingCube to keep the same look and feel as > other > > >> KDE Games, although I modernized the code a bit (KJumpingCube was > made in > > >> 1999!). The README explains both how to play and how the code is > > >> structured, so it might be useful to read. > > >> > > >> The gameplay is actually based on a shareware game for Windows 3.1 > that I > > >> was nostalgic about, maybe someone here even played the original :) > > >> > > >> * Source: https://invent.kde.org/albertvaka/kdominate > > >> * Review checklist: > > >> https://invent.kde.org/albertvaka/kdominate/-/issues/1 > > >> > > >> Albert > > > > > --000000000000d87349064edf7bf0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">=F0=9F=A5=B3=C2=A0What are the next steps, now? The wiki m= entions the case where the project is not accepted (<i>After two months in = KDE Review the repo should be moved back to playground or moved to unmainta= ined</i>) but says nothing about the case the project is accepted.</div><br= ><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, A= pr 6, 2026 at 4:13=E2=80=AFPM Albert Astals Cid <<a href=3D"mailto:aacid= @kde.org" target=3D"_blank">[email protected]</a>> wrote:<br></div><blockquo= te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px = solid rgb(204,204,204);padding-left:1ex">El dijous, 26 de mar=C3=A7 del 202= 6, a les 17:31:55 (Hora d=E2=80=99estiu d=E2=80=99Europa <br> central), Albert Vaca Cintora va escriure:<br> > The following checkboxes still need ticking :)<br> > <br> > - A screenshot in product-screenshots<br> > - A <a href=3D"http://bugs.kde.org" rel=3D"noreferrer" target=3D"_blan= k">bugs.kde.org</a> product (file a sysadmin ticket)<br> > <br> > These two are done (but I think I shouldn't tick the boxes myself,= right?).<br> <br> For the ones that are factual, i think you can. Either there is or there is= <br> not a screenshot/product. I have done it for you anyway.<br> <br> > <br> > - Check the code with some sanity tools like clazy or clang-tidy, if n= ot<br> > already done as part of CI runs<br> > <br> > Not automated in the CI but I ran clazy a few times during development= and<br> > fixed the findings.<br> <br> I also checked this one.<br> <br> > <br> > - Passing KDE neon build<br> > <br> > No idea what needs to be done here.<br> > <br> > <a href=3D"https://invent.kde.org/games/kdominate/-/issues/1" rel=3D"n= oreferrer" target=3D"_blank">https://invent.kde.org/games/kdominate/-/issue= s/1</a><br> <br> Everything is checked now.<br> <br> Cheers,<br> =C2=A0 Albert<br> <br> <br> > <br> > On Sun, Mar 1, 2026 at 2:31=E2=80=AFAM Albert Vaca Cintora <<a href= =3D"mailto:[email protected]" target=3D"_blank">[email protected]</a>= ><br> > <br> > wrote:<br> > > The repo has now been moved to <a href=3D"https://invent.kde.org/= games/kdominate" rel=3D"noreferrer" target=3D"_blank">https://invent.kde.or= g/games/kdominate</a> so<br> > > the review can proceed.<br> > > <br> > > On Fri, Feb 27, 2026 at 9:20=E2=80=AFPM Albert Vaca Cintora <<= a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]= om</a>><br> > > <br> > > wrote:<br> > >> Hi,<br> > >> <br> > >> I wrote KDominate, a simple desktop game that I would like to= make part<br> > >> of KDE Games.<br> > >> <br> > >> I reused the UI from KJumpingCube to keep the same look and f= eel as other<br> > >> KDE Games, although I modernized the code a bit (KJumpingCube= was made in<br> > >> 1999!). The README explains both how to play and how the code= is<br> > >> structured, so it might be useful to read.<br> > >> <br> > >> The gameplay is actually based on a shareware game for Window= s 3.1 that I<br> > >> was nostalgic about, maybe someone here even played the origi= nal :)<br> > >> <br> > >> * Source: <a href=3D"https://invent.kde.org/albertvaka/kdomin= ate" rel=3D"noreferrer" target=3D"_blank">https://invent.kde.org/albertvaka= /kdominate</a><br> > >> * Review checklist:<br> > >> <a href=3D"https://invent.kde.org/albertvaka/kdominate/-/issu= es/1" rel=3D"noreferrer" target=3D"_blank">https://invent.kde.org/albertvak= a/kdominate/-/issues/1</a><br> > >> <br> > >> Albert<br> <br> <br> <br> <br> </blockquote></div> --000000000000d87349064edf7bf0--