Re: KDE review request: KDominate
Albert Astals Cid <[email protected]> Tue, 07 Apr 2026 23:58:49 +0200
| Newsgroups | gmane.comp.kde.devel.core |
|---|---|
| Message-ID | <8761913.NyiUUSuA9g@xps15> |
El dimarts, 7 d=E2=80=99abril del 2026, a les 16:19:55 (Hora d=E2=80=99esti= u d=E2=80=99Europa central), Albert Vaca Cintora va escriure: > =F0=9F=A5=B3 What are the next steps, now? The wiki mentions the case whe= re the > project is not accepted (*After two months in KDE Review the repo should = be > moved back to playground or moved to unmaintained*) but says nothing about > the case the project is accepted. I'd say you create a MR to change https://invent.kde.org/sysadmin/repo-metadata/-/blob/master/projects-invent= /games/kdominate/metadata.yaml?ref_type=3Dheads from in-review to reviewed. And that's it? Then ideally you think about doing a release :) Cheers, Albert >=20 > On Mon, Apr 6, 2026 at 4:13=E2=80=AFPM Albert Astals Cid <[email protected]> = wrote: > > El dijous, 26 de mar=C3=A7 del 2026, a les 17:31:55 (Hora d=E2=80=99est= iu d=E2=80=99Europa > >=20 > > central), Albert Vaca Cintora va escriure: > > > The following checkboxes still need ticking :) > > >=20 > > > - A screenshot in product-screenshots > > > - A bugs.kde.org product (file a sysadmin ticket) > > >=20 > > > These two are done (but I think I shouldn't tick the boxes myself, > >=20 > > right?). > >=20 > > For the ones that are factual, i think you can. Either there is or there > > is > > not a screenshot/product. I have done it for you anyway. > >=20 > > > - Check the code with some sanity tools like clazy or clang-tidy, if = not > > > already done as part of CI runs > > >=20 > > > Not automated in the CI but I ran clazy a few times during development > >=20 > > and > >=20 > > > fixed the findings. > >=20 > > I also checked this one. > >=20 > > > - Passing KDE neon build > > >=20 > > > No idea what needs to be done here. > > >=20 > > > https://invent.kde.org/games/kdominate/-/issues/1 > >=20 > > Everything is checked now. > >=20 > > Cheers, > >=20 > > Albert > > =20 > > > On Sun, Mar 1, 2026 at 2:31=E2=80=AFAM Albert Vaca Cintora <albertvak= [email protected] > > >=20 > > > wrote: > > > > The repo has now been moved to https://invent.kde.org/games/kdomina= te > >=20 > > so > >=20 > > > > the review can proceed. > > > >=20 > > > > On Fri, Feb 27, 2026 at 9:20=E2=80=AFPM Albert Vaca Cintora < > >=20 > > [email protected]> > >=20 > > > > wrote: > > > >> Hi, > > > >>=20 > > > >> I wrote KDominate, a simple desktop game that I would like to make > >=20 > > part > >=20 > > > >> of KDE Games. > > > >>=20 > > > >> I reused the UI from KJumpingCube to keep the same look and feel as > >=20 > > other > >=20 > > > >> KDE Games, although I modernized the code a bit (KJumpingCube was > >=20 > > made in > >=20 > > > >> 1999!). The README explains both how to play and how the code is > > > >> structured, so it might be useful to read. > > > >>=20 > > > >> The gameplay is actually based on a shareware game for Windows 3.1 > >=20 > > that I > >=20 > > > >> was nostalgic about, maybe someone here even played the original :) > > > >>=20 > > > >> * Source: https://invent.kde.org/albertvaka/kdominate > > > >> * Review checklist: > > > >> https://invent.kde.org/albertvaka/kdominate/-/issues/1 > > > >>=20 > > > >> Albert