Re: D27748: Compose RELEASE_SERVICE_VERSION into palapeli version

Hi Albert,

Might it make sense to insert a “.0.” after the “2.1” in the hope that someone might come along and fix a bug or two in the gameplay, plus an explanatory comment about that?

The fixer should then bump that zero to indicate that bugs directly affecting end-users had been fixed in that version --- as opposed to the game having changes made to adapt to changing libraries, or receiving fixes to those library-caused changes, or even just being re-released unchanged or with some translation changes (which AFAIK can happen).

Ditto for other KDE Games: many no longer have maintainers.

Cheers,
Ian W.


> On 1 Mar 2020, at 10:57 am, Albert Astals Cid <[email protected]> wrote:
> 
> View Revision
> aacid created this revision.
> Herald added a reviewer: KDE Games.
> Herald added a subscriber: kde-games-devel.
> aacid requested review of this revision.
> 
> REVISION SUMMARY
> Palapeli version was increased to 2.1 "recently" and not so many changes have been done since them
> so asserting the verison number is stuck in the past is a bit too much, but still having it move with
> each new release is important for reproducibility of issues, etc. so compromise and append the version at the end
> 
> 
> REPOSITORY
> R423 Palapeli
> 
> BRANCH
> master
> 
> REVISION DETAIL
> https://phabricator.kde.org/D27748
> 
> AFFECTED FILES
> CMakeLists.txt
> src/CMakeLists.txt
> src/main.cpp
> 
> To: aacid, KDE Games
> Cc: kde-games-devel