Re: Unittests!

On Sunday 7. November 2010 17.10.41 C. Boemann wrote:
> On Sunday 07 November 2010 15:38:37 Thomas Zander wrote:
> > On Sunday 7. November 2010 13.04.42 Boudewijn Rempt wrote:
> > > For Krita, I've the habit of sending out a weekly mail with all tests
> > > that
> > 
> > > fail. Here's the same for all of KOffice:
> > []
> > 
> > >         213 - kotext-odf-TestLoading (Failed) (this one fails because i
> > > 
> > > haven't qtscript installed. I guess it would fail even if I had).
> > 
> > You guessed right, the test shows a bug in bookmark saving. It
> > demonstrates a usecase where the ODF we export is incorrect.
> > So this would be the first release in quite a while where the unit test
> > is completely correct again :)
> > It would be nice to fix this issue too before the release, I guess you'll
> > all agree.
> > 
> > Anyone that has experience with the bookmark odf saving code can take a
> > look? The bug is registered as; 250834
> 
> I've just looked at it and it appears there is no saving code at all. 

Notice that in the dir you run the unit test in I now create two files that show 
the content, do a diff to see what the in-memory data is.
Also the last test that is run leaves behind a 'test.odt'. I'll attach the 
bookmarks one here.

As far as I can tell, the simple bookmarks get saved fine, the multi parags one 
gets closed too soon.

> I
> don't have experience but as you say it would be really nice if it gets
> fixed. I'll look more at it, but if someone with more experience wants to
> work on it, then please reply here and i'll gladly step aside.

Thanks for looking at it :)

-- 
Thomas Zander

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel