Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y attributes in EnhancedPathShape

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5978/#review8994
-----------------------------------------------------------


It looks wellcode, but I don't know this shape so I havn't actually looked at what it does.

Still I found a couple of style issues.

Someone else please look at it, as I don't feel comfortable


trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
<http://svn.reviewboard.kde.org/r/5978/#comment9760>

    style: there shouldn't be an empty line here.
    
    You do it several place later in the diff too



trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
<http://svn.reviewboard.kde.org/r/5978/#comment9759>

    style it should be if (m.. and not if( m..


- Casper


On 2010-11-26 17:45:40, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5978/
> -----------------------------------------------------------
> 
> (Updated 2010-11-26 17:45:40)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Path-stretchpoint-x and path-stretchpoint-y are needed for example in round-rectangles to have the corners round after stretching, without it the corners would be eliptical.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.h 1201000 
>   trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 1201000 
> 
> Diff: http://svn.reviewboard.kde.org/r/5978/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel