Re: Review Request: Fix for Bug 243923

"Thorsten Zachmann" <[email protected]> Sun, 28 Nov 2010 05:08:12 -0000
Newsgroups gmane.comp.kde.devel.koffice
Message-ID <[email protected]>

> On 2010-11-18 08:42:37, Thorsten Zachmann wrote:
> > Looks good. Also documents loaded from file still look like they have looked before.

Can you please close the review request as the fix has been committed.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5897/#review8808
-----------------------------------------------------------


On 2010-11-18 05:14:38, Ganesh Paramasivam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5897/
> -----------------------------------------------------------
> 
> (Updated 2010-11-18 05:14:38)
> 
> 
> Review request for KOffice, Thomas Zander and Ganesh Paramasivam.
> 
> 
> Summary
> -------
> 
> Fix for bug 243923 - (http://bugs.kde.org/show_bug.cgi?id=243923)
> In loadParagraph check whether we are working on a existing block or a new block ( by checking whether the cursor's position is at the beginning of the block or not ). If we are working on a existing block, then don't apply the paragraph style.
> 
> 
> This addresses bug 243923.
>     https://bugs.kde.org/show_bug.cgi?id=243923
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1198287 
> 
> Diff: http://svn.reviewboard.kde.org/r/5897/diff
> 
> 
> Testing
> -------
> 
> Fix has been verified with the two use-cases specified in the bug report.
> 
> 
> Thanks,
> 
> Ganesh
> 
>

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel