Re: Fwd: Re: Calligra translations are enabled

"Aaron J. Seigo" <[email protected]> Fri, 17 Dec 2010 16:30:19 -0800
Newsgroups gmane.comp.kde.devel.koffice
Message-ID <[email protected]>
On Friday, December 17, 2010, Cyrille Berger Skott wrote:
> On Friday 17 December 2010, Aaron J. Seigo wrote:
> > * unique library prefixes
> > * unique header install prefix
> 
> and a gazillion plugins,

i included those in the CMakeLists.txt counts

> desktop files,

renames and content changes for these are scriptable. there are 17 in libs/, 
and 102 in kword/, kspread/ and kpresenter/ combined.

changes to the ServiceType entries would be needed, they are also easily 
scriptable. then there's the calls to KServiceTypeTrader in the C++ code, but 
those are also very easy to grep for as they are rather unambiguous strings.

in fact: there are 16 ServiceTypes installed by caligra/libs/. of those, 15 
are prefixed with "KOffice/", and one with "KoReport/"

grepping for that shows 22 instances where those are used in the C++ code from 
KServiceTypeTraders .. and every single one of those instances is in libs/ 
(koffice/calligra is quite reasonably designed :)

so changing the ServiceTypes is probably 30 minutes with of work from the 
command line as everything is easily findable and scirptable (`perl -pi -e` is 
your friend)

> rcs,

there is one rc file in libs/ which would need to be renamed, and the renamed 
apps (words, stage, numbers) need this done anyways. in fact i see it has been 
started (though not yet completed as the content hasn't been updated as needed 
in all cases). the rest is just install prefixes in the CMakeList.txt. 

> images...

image naming can similarly be scripted, and it seems that the images are 
really just dependent on path prefixes. there are only 47 affected images in 
libs/ and 205 in kword/, kspread/ and kpresenter/ combined.

a few need renaming, mostly it's just the install prefix which is a one liner 
(easily scripted) in the relevant CMakeLists.txt files.

> And translations... 

those need moving anyways.

> and whatever else I am forgetting about.

docs, which need to be moved around for the renamed apps anyways.

> Which is the problem, it adds up.

obviously it's the calligra team's call how much a clean break is worth.

all i can offer is that we've made such changes before in plasma (which does 
only have ~1/4th the lines of code, but in terms of plugins and similar 
installables is similarly complex; plasma has nearly 3 times the number of 
.desktop files, plugins, etc.), so i know how first hand that it's definitely 
a bit fiddly, but it's doable in a small amount of time.

and i'm assuming you only need to worry about libs/, kword/, kspread/ and 
kpresenter/ changing names. libs/ causes some knock-on effects to other 
CMakeLists.txt files and ServiceTypeTrader calls, but it's all included in the 
numbers above, which are really much smaller than one might expect for a code 
base of that size.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel
signature.asc (application/pgp-signature, 198 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)

iEYEABECAAYFAk0MAJ0ACgkQ1rcusafx20NHIQCeJGHgdKPhB7e5mEkO/+6xMDBw
P94AniQgaecoo4+axwASYPEbMg8pFlkS
=gfcM
-----END PGP SIGNATURE-----